Re: RFS: clipit

[Cristian Henzel <oss@web-tm.com>]

Hello,


I have moved the autogen.sh call before dh_auto_configure and have also
managed to fix the gettext problem by replacing the gettext command with
autopoint. autopoint does basically the same thing as gettext, but
without that naging user input request.
I haven't made these changes upstream yet, before you tell me that this
is an acceptable solution.
If this is acceptable, I will make a new upstream release and repackage
without any patches.

The only warnings left right now are:

configure: WARNING: unrecognized options: --disable-maintainer-mode

and

dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be avoided
if "debian/clipit/usr/bin/clipit" were not uselessly linked against it
(they use none of its symbols).

but this last one is unnecessary, because my program actually uses
functions from libpthread.so (pthread_exit), so it needs that library...


Best regards,
Mit freundlichen Grüßen,

Henzel Cristian

On 11/11/2010 09:44 PM, Benoît Knecht wrote:
> Hi again,
> 
> Cristian Henzel wrote:
>> I have managed to get rid of the dpkg-shlibdeps warning by using the
>> flag '-Wl,--as-needed'. I have also solved the autogen.sh problem by
>> overriding dh_clean like this:
>>
>> override_dh_clean:
>> 	dh_clean
>> 	./autogen.sh
> 
> You should override dh_auto_configure instead, like so:
>   override_dh_auto_configure:
>   	./autogen.sh
>   	dh_auto_configure
> 
>> [...]
>>
>> The only problems (at least as far as I can tell) left right now are
>> that autogen.sh asks for user input when running (this is because of
>> gettext)
> 
> This is indeed an issue, the build process should not require user
> input. I don't know how to fix it though, I'll need to have a closer
> look; or maybe someone else can be of assistance.
> 
>> and I'm not sure if this is allowed, that a pretty big patchfile gets
>> created because of the extra files that autogen.sh creates
> 
> This should be solved by not calling ./autogen.sh at the end of the
> clean target.
> 
>> I have also fixed the problems with the manpage and have made a new
>> upstream release to include all of the changes.
> 
> Great, thanks!
> 
>> Regarding your comment:
>>
>>> This is mostly nitpicking, so feel free to ignore.
>>
>> I have to say that I appreciate every constructive comments and I thank
>> you very much for your patience and the great help.
> 
> You're very welcome. And thank _you_ very much for packaging this
> software!
> 
> Cheers,
>