Re: RFS: clipit

[Cristian Henzel <oss@web-tm.com>]

Sorry, sending the message again because I forgot to cc
debian-mentors@lists.debian.org.


Hello,


I have managed to get rid of the dpkg-shlibdeps warning by using the
flag '-Wl,--as-needed'. I have also solved the autogen.sh problem by
overriding dh_clean like this:

override_dh_clean:
	dh_clean
	./autogen.sh

I couldn't use the --autoconf and --automake flags of dh as you
suggested because my package also needs gettext (and a couple of other
things) to be run.
The only problems (at least as far as I can tell) left right now are
that autogen.sh asks for user input when running (this is because of
gettext) and I'm not sure if this is allowed, that a pretty big
patchfile gets created because of the extra files that autogen.sh
creates and that there are a couple of warnings left:

dpkg-source: warning: newly created empty file 'intltool-extract.in'
will not be represented in diff
dpkg-source: warning: newly created empty file 'intltool-merge.in' will
not be represented in diff
dpkg-source: warning: newly created empty file 'intltool-update.in' will
not be represented in diff
dpkg-source: warning: executable mode 0755 of 'configure' will not be
represented in diff
[...]
dpkg-gencontrol: warning: Depends field of package clipit: unknown
substitution variable ${shlibs:Depends}

I have also fixed the problems with the manpage and have made a new
upstream release to include all of the changes.

Regarding your comment:

> This is mostly nitpicking, so feel free to ignore.

I have to say that I appreciate every constructive comments and I thank
you very much for your patience and the great help.


Best regards,
Mit freundlichen Grüßen,

Henzel Cristian

On 11/11/2010 04:06 PM, Benoît Knecht wrote:
> Benoît Knecht wrote:
>> Cristian Henzel wrote:
>>> I am looking for a sponsor for my package "clipit".
>>>
>>> * Package name    : clipit
>>>   Version         : 1.2.1-1
>>>   Upstream Author : Cristian Henzel <oss@web-tm.com>
>>> * URL             : http://sourceforge.net/projects/gtkclipit/
>>> * License         : GPLv3
>>>   Section         : misc
>>>
>>> It builds these binary packages:
>>> clipit     - lightweight GTK+ clipboard manager
>>>
>>> The package appears to be lintian clean.
>>>
>>> The upload would fix these bugs: 603131
>>
>> I just did a quick review of your package:
>>
>> [...]
> 
> One more thing (not specifically debian-related), about your man page
> (doc/clipit.1):
> 
>  - You use non-standard section names (such as "ACTIONS" and "CLI
>    EXAMPLES"). You should stick to the standard names described in
>    man-pages(7), and have subsections if you need more specific names.
> 
>  - A ".TP" is missing before the "-p, --primary" option.
> 
>  - (This is mostly nitpicking, so feel free to ignore.) The date is
>    ambiguous (is it 1st November or 11th January?); the ISO 8601 date is
>    probably a better choice (2010-11-01, assuming you meant November).
>    While I'm nitpicking: I'd also use some punctuation at the end of
>    each item in the OPTIONS section.
> 
>  - On a less technical note, the examples section would be clearer with
>    some explanation of each case ("copying from stdin to the clipboard",
>    "copying argument to the clipboard", etc.)
> 
> Cheers,
>