[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: clipit



Benoît Knecht wrote:
> Cristian Henzel wrote:
> > I am looking for a sponsor for my package "clipit".
> > 
> > * Package name    : clipit
> >   Version         : 1.2.1-1
> >   Upstream Author : Cristian Henzel <oss@web-tm.com>
> > * URL             : http://sourceforge.net/projects/gtkclipit/
> > * License         : GPLv3
> >   Section         : misc
> > 
> > It builds these binary packages:
> > clipit     - lightweight GTK+ clipboard manager
> > 
> > The package appears to be lintian clean.
> > 
> > The upload would fix these bugs: 603131
> 
> I just did a quick review of your package:
> 
> [...]

One more thing (not specifically debian-related), about your man page
(doc/clipit.1):

 - You use non-standard section names (such as "ACTIONS" and "CLI
   EXAMPLES"). You should stick to the standard names described in
   man-pages(7), and have subsections if you need more specific names.

 - A ".TP" is missing before the "-p, --primary" option.

 - (This is mostly nitpicking, so feel free to ignore.) The date is
   ambiguous (is it 1st November or 11th January?); the ISO 8601 date is
   probably a better choice (2010-11-01, assuming you meant November).
   While I'm nitpicking: I'd also use some punctuation at the end of
   each item in the OPTIONS section.

 - On a less technical note, the examples section would be clearer with
   some explanation of each case ("copying from stdin to the clipboard",
   "copying argument to the clipboard", etc.)

Cheers,

-- 
Benoît Knecht


Reply to: