Re: RFS: galinette
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 2010-10-01 12:23, Paul McEnery wrote:
> Dear mentors,
>
Hi
I have had a look at your package; please note that I am not a DD (which
means I cannot sponsor it, even if you address all my comments) and I
ran out of time to do a full review, so I only checked a few things.
Nevertheless I hope you can use my comments.
> I'm not sure the package is ready for upload just yet. In particular,
> I am having trouble eliminating excessive linking brought about by
> cmake. In particluar, I am getting the following warnings:
>
> [...]
> dpkg-shlibdeps: warning: dependency on libftdi.so.1 could be avoided
> if "debian/galinette-nox/usr/bin/galinette-flash" were not uselessly
> linked against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libfontconfig.so.1 could be
> avoided if "debian/galinette/usr/bin/galinette" were not uselessly
> linked against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libm.so.6 could be avoided if
> "debian/galinette/usr/bin/galinette" were not uselessly linked against
> it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libatk-1.0.so.0 could be
> avoided if "debian/galinette/usr/bin/galinette"were not uselessly
> linked against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libxml2.so.2 could be avoided
> if "debian/galinette/usr/bin/galinette" were not uselessly linked
> against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libftdi.so.1 could be avoided
> if "debian/galinette/usr/bin/galinette" were not uselessly linked
> against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on librt.so.1 could be avoided if
> "debian/galinette/usr/bin/galinette" werenot uselessly linked against
> it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libpthread.so.0 could be
> avoided if "debian/galinette/usr/bin/galinette"were not uselessly
> linked against it (they use none of its symbols).
> dpkg-shlibdeps: warning: dependency on libgio-2.0.so.0 could be
> avoided if "debian/galinette/usr/bin/galinette"were not uselessly
> linked against it (they use none of its symbols).
> [..]
>
>
> I have done some investigation, and it appears that cmake has
> automatically added some of these without any good reason. Hopefully a
> mentor with some cmake experience can help me eliminate these issues
> (despite them not being a specific packaging issue)...
>
> Regards,
> Paul.
>
>
By the looks of it you have fixed this by now. :)
Anyhow - on to my short review:
d/control:
- Redundant B-D on quilt; it is a 3.0 (quilt) package.
- Standards-Versions is at 3.9.1 (package is at 3.8.4)
- Section: utils in galinette-nox and galinette not
needed (due to it being present in Source as well)
d/copyright:
- looks good.
d/rules:
- The --buildsystem option is probably not required as
dh can guess common build systems.
- You may want to double check whether dh passes on
CFLAGS and LDFLAGS to cmake - as I recall it does not
(but I did not have the time to double check).
if not see [1] for how to fix it.
patches/001-linking-fix.patch
- Could use some cleaning (unrelated/whitespace changes)
- No description/author.
You may be able to replace (most of) this patch by passing extra options
to cmake via dh_auto_configure[1]
A little lintian output (all tags enabled, even those you are usually
not required to fix):
N: Processing binary package libgalinette0 (version 1.1-1) ...
X: libgalinette0: shlib-calls-exit usr/lib/libgalinette.so.0
I: libgalinette0: no-symbols-control-file usr/lib/libgalinette.so.0
I would strongly recommend that you implement a symbols file for
libgalinette; have a look at [2]. It can help you discover if
libgalinette has broken backwards compatibility as as well allows dpkg
to calculate minimum needed versions for packages depending on libgalinette.
The exit tag appears to be correct; but it is in a call-back method
so it is probably okay (even if the callback is installed by default).
Also note that it is usually not required to fix or even override
X (experimental) tags.
You can get more information about these tags by using:
lintian-info -t <tag>
If you have any questions to this or other questions to your
package/packaging, feel free to write back.
~Niels
[1] e.g. by adding something like this to your debian/rules file
(requires debhelper >= 7.0.50~):
override_dh_auto_configure:
dh_auto_configure -- -DCMAKE_C_FLAGS="$(CFLAGS)"
-DCMAKE_CXX_FLAGS="$(CFLAGS)" \
-DCMAKE_SHARED_LINKER_FLAGS="-Wl,--no-undefined" \
-DCMAKE_MODULE_LINKER_FLAGS="-Wl,--no-undefined" \
-DCMAKE_EXE_LINKER_FLAGS="-Wl,--no-undefined <more opts>"
[2] http://wiki.debian.org/UsingSymbolsFiles
man deb-symbols dpkg-gensymbols
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEAREIAAYFAkyt5T4ACgkQVCqoiq1YlqyRkwCeNQCdrTWlYauM+7EBA3NnU3zb
5z0AoNie3D8rymx/ZF5ANEQR3VkE6Zt2
=9ErD
-----END PGP SIGNATURE-----
Reply to: