[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1115476: RFS: mousam/1.4.0+ds-1 [ITP] -- GUI application for the Weather



Thanks for your time.

On Wednesday, 17 September 2025 at 18:37, Alexander Sulfrian <alexander@sulfrian.net> wrote:

> > Vcs: https://salsa.debian.org/amin_modaresi/mousam
> 
> This returns "404: Page not found".

Oh sorry! I made it private! But it is now public.

> 
> d/copyright references a "tractor team". I cannot find another
> reference. Is this maybe a copy&paste error? You may want to use a
> common license block for the GPL-3+ license and only reference the
> license name for the different files.
> 
> d/copyright is missing the license for the appdata file in data/.

OK, I fixed these.

> Why do you override dh_auto_test in d/rules? pybuild will figure out, if
> there are no tests and will not fail, but actually there are automatic
> tests that validate the glib schema.
> 

pybuild can't understand that there is not any test!
I don't know why?! but I think it is not important!


> Maybe you want to disable the gtk_update_icon_cache and
> update_desktop_database steps during the build and drop the required

NO, they are needed.

> dependencies for it. This is useless during the build and there already
> should be triggers to execute the required steps after the package is
> installed by dpkg.

OK,

See these commits:

https://salsa.debian.org/amin_modaresi/mousam/-/commit/6c949a7f88e1a318dba677f81f167fbf1159f3cd

https://salsa.debian.org/amin_modaresi/mousam/-/commit/ba3ab5660dc1cc042f85fdbe2119d340e0599a3f

but python3-all is needed.

> 
> You may want to add an override for the lintian repeated-path-segment

I think it is not very importand,

> message. But you propably should not override the no-manual-page
> warning. This is a bug according to the policy and should be fixed.


OK,

See: 
https://salsa.debian.org/amin_modaresi/mousam/-/commit/6e98f10e1e2c6715860ffe8755b03c89aa0d99e5


>The application opens network connections to the following >services 
>during startup to check if internet access is available (it stops >after 
>the first one succeeds):

I added a patch that uses gnu.org and example.com instead of google and baidu

https://salsa.debian.org/amin_modaresi/mousam/-/commit/c5d8375b0c6906b0a6639cd24b3399e518315c39

And I added a NOTE to the manpage for this.

https://salsa.debian.org/amin_modaresi/mousam/-/blob/master/debian/mousam.1?ref_type=heads#L29


Reply to: