Hi, On 9/17/25 11:14, Seyed Mohamad Amin Modaresi wrote:
Vcs: https://salsa.debian.org/amin_modaresi/mousam
This returns "404: Page not found". I have done a review based on the dsc-File on mentors:d/copyright references a "tractor team". I cannot find another reference. Is this maybe a copy&paste error? You may want to use a common license block for the GPL-3+ license and only reference the license name for the different files.
d/copyright is missing the license for the appdata file in data/.Why do you override dh_auto_test in d/rules? pybuild will figure out, if there are no tests and will not fail, but actually there are automatic tests that validate the glib schema.
Maybe you want to disable the gtk_update_icon_cache and update_desktop_database steps during the build and drop the required dependencies for it. This is useless during the build and there already should be triggers to execute the required steps _after_ the package is installed by dpkg.
Depending on python3 and python3-all should not be required. The ninja-build and python3-setuptools dependencies could also be dropped, because they are a hard dependencies of meson and are not used directly in the project. You may want to use libglib2.0-dev as dependency instead of libglib2.0-bin and libgio-2.0-dev-bin. Are there any reasons for the versioned dependencies of the binary package? I could not find any reference for the specific versions in the upstream code.
Any reason you did not base your work on the debian packaging in the upstream repo?
You may want to add an override for the lintian repeated-path-segment message. But you propably should not override the no-manual-page warning. This is a bug according to the policy and should be fixed.
Alex
Attachment:
OpenPGP_0x0BD13B63E2A9AF58.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature