Control: tags -1 +moreinfo I have no decision making athority within the Debian Project. You may reject this review if you wish. Osman, Review of upload: 2025-07-21 07:12 Test 1 (reproducibility): Information only, not a blocker Not being performed until bug below is fixed and accurate documentation written. Bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1108550 Test 2 (pbuilder build): Information only * Good Test 3 (pbuilder build --twice): Information only * Good Test 4 (sbuild): Information only Lintian: W: apachetop source: maintainer-upload-has-incorrect-version-number 0.23.2- 4.2~mentors1 [debian/changelog:1] N: N: A maintainer upload should have a Debian revision without dots. Revisions N: with dots are reserved for Non-Maintainer Uploads (NMUs). If you do a N: maintainer-upload with dots a potential NMU'er has problems choosing a N: correct version number. N: N: Visibility: warning N: Show-Always: no N: Check: nmu N: N: I: apachetop source: superficial-tests [debian/tests/control] N: N: The source package declares tests in the debian/tests/control file but N: provides only tests with a superficial restriction. N: N: Please provide more meaningful tests. N: N: Please refer to N: https://lists.debian.org/debian-devel-announce/2019/08/msg00003.html, N: Bug#932870, and N: https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst N: for details. N: N: Visibility: info N: Show-Always: no N: Check: testsuite N: N: P: apachetop: manual-page-for-system-command [usr/sbin/apachetop] N: N: The command in /sbin or /usr/sbin are system administration commands; N: their manual pages thus belong in section 8, not section 1. N: N: Please check whether the command is actually useful to non-privileged user N: in which case it should be moved to /bin or /usr/bin, or alternatively the N: manual page should be moved to section 8 instead, ie. /usr/share/man/man8. N: N: Please refer to Bug#348864, Bug#253011, and the hier(7) manual page for N: details. N: N: Visibility: pedantic N: Show-Always: no N: Check: documentation/manual N: Renamed from: command-in-sbin-has-manpage-in-incorrect-section Test 5 (ratt): Information only, not a blocker Note: Possible false positives. * Good Test 6 (debian/watch): Information only * Good Test 7 (licenserecon): Information only * Good Summary ======= A few lintian issues to look at. As you are adopting the package, the package should be '-5' not '-4.2~mentors1'. Your 'debian/changelog' is a little messing and would be difficult to read and understand. I would be more verbose and break down entries per thing as below. * Adopting package. (Closes: #1098915) Close the other ITA bug manually, not in the changelog. Be more descriptive in the rest of the changelog. Tags ==== If a 'moreinfo' tag has been added to your RFS bug. You can remove the tag using the line below at the top of a reply that is supplying information and/or indicating a new upload. Control: tags -1 -moreinfo Regards Phil -- Blog: https://blog.kathenas.org Buy me a coffee: https://buymeacoffee.com/kathenasorg GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B
Attachment:
signature.asc
Description: This is a digitally signed message part