Control: tags -1 +moreinfo
<REPLACE_WITH_SUBMITTER>,
Preamble...
Thank you for taking the time to prepare this package and your contribution to
the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Issue
Running lintian...
N:
W: meshlab: possible-unindented-list-in-extended-description line 13
N:
N: The package "Description:" contains an unindented line which starts with a
N: dash (-) or asterisk (*). If this was meant to be a list of items these
N: lines need to be indented (dselect would word-wrap these lines otherwise).
N:
N: Please refer to Description (Section 5.6.13) in the Debian Policy Manual
N: for details.
N:
N: Visibility: warning
N: Show-Always: no
N: Check: fields/description
N:
N:
I: meshlab source: anticipated-repack-count 2022.02+dfsg1-1
N:
N: The version contains the string +dfsgN where N is a low number as in
N: +dfsg1.
N:
N: Normally it is not necessary to repackage an upstream source package more
N: than once. You can omit the repack count. In most cases +dfsg-1 is enough.
N:
N: If you really need to bump it, just go straight to +dfsg2-1.
N:
N: Please refer to
N: https://lists.debian.org/debian-devel/2021/10/msg00026.html for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: fields/version/repack/count
N:
N:
I: meshlab: desktop-entry-lacks-keywords-entry
[usr/share/applications/meshlab.desktop]
N:
N: This .desktop file is either missing a Keywords entry, or it does not
N: contain keywords above and beyond those already present in the Name or
N: GenericName entries.
N:
N: The Keywords field is intended to show keywords relevant for a .desktop
N: file.
N:
N: Desktop files are organized in key-value pairs and are similar to INI
N: files.
N:
N: The desktop-file-validate tool in the desktop-file-utils package may be
N: useful when checking the syntax of desktop entries.
N:
N: Please refer to
N:
https://specifications.freedesktop.org/desktop-entry-spec/latest/ar01s06.html,
N: Bug#693918, and
N: https://wiki.gnome.org/Initiatives/GnomeGoals/DesktopFileKeywords for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: menu-format
N:
N:
I: meshlab: hardening-no-fortify-functions [usr/lib/x86_64-linux-
gnu/meshlab/plugins/libio_e57.so]
N:
N: This package provides an ELF binary that lacks the use of fortified libc
N: functions. Either there are no potentially unfortified functions called by
N: any routines, all unfortified calls have already been fully validated at
N: compile-time, or the package was not built with the default Debian
N: compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags
N: directly, be sure to import CPPFLAGS.
N:
N: NB: Due to false-positives, Lintian ignores some unprotected functions
N: (e.g. memcpy).
N:
N: Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N: details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/hardening
N:
N:
I: meshlab source: patch-not-forwarded-upstream [debian/patches/0008-e57-Fix-
build-error-from-missing-include.patch]
N:
N: According to the DEP-3 headers, this patch has not been forwarded
N: upstream.
N:
N: Please forward the patch and try to have it included in upstream's version
N: control system. If the patch is not suitable for that, please mention
N: not-needed in the Forwarded field of the patch header.
N:
N: Please refer to social contract item 2, Coordination with upstream
N: developers (Section 3.1.4) in the Debian Developer's Reference, Changes to
N: the upstream sources (Section 4.3) in the Debian Policy Manual, and
N: Bug#755153 for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: debian/patches/dep3
N: Renamed from: send-patch
N:
N:
I: meshlab source: patch-not-forwarded-upstream [debian/patches/0008-u3d-Use-
system-zlib-jpeg-png.patch]
N:
I: meshlab source: patch-not-forwarded-upstream [debian/patches/0009-Fix-
spelling-errors-in-strings.patch]
N:
I: meshlab source: patch-not-forwarded-upstream [debian/patches/06_format-
security.patch]
N:
I: meshlab source: patch-not-forwarded-upstream
[debian/patches/18_structuresynth_license.patch]
N:
I: meshlab source: patch-not-forwarded-upstream [debian/patches/22_find-
plugins.patch]
N:
I: meshlab source: patch-not-forwarded-upstream [debian/patches/27_Remove-more-
__date__-usages.patch]
N:
I: meshlab: spelling-error-in-binary ment meant [usr/lib/x86_64-linux-
gnu/meshlab/plugins/librender_radiance_scaling.so]
N:
N: Lintian found a spelling error in the given binary. Lintian has a list of
N: common misspellings that it looks for. It does not have a dictionary like
N: a spelling checker does.
N:
N: If the string containing the spelling error is translated with the help of
N: gettext or a similar tool, please fix the error in the translations as
N: well as the English text to avoid making the translations fuzzy. With
N: gettext, for example, this means you should also fix the spelling mistake
N: in the corresponding msgids in the *.po files.
N:
N: You can often find the word in the source code by running:
N:
N: grep -rw <word> <source-tree>
N:
N: This tag may produce false positives for words that contain non-ASCII
N: characters due to limitations in strings.
N:
N: Visibility: info
N: Show-Always: no
N: Check: binaries/spelling
N:
N:
P: meshlab source: source-contains-autogenerated-visual-c++-file
[src/external/u3d/src/IDTF/IFXResource.h]
N:
N: The following file is autogenerated by Microsoft Visual C++.
N:
N: They are usually provided for the convenience of users. These files
N: usually just take up space in the tarball and are of no use in Debian.
N:
N: Check if upstream also provides source-only tarballs that you can use as
N: the upstream distribution instead. If not, you may want to ask upstream to
N: provide source-only tarballs.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: cruft
N:
N:
P: meshlab source: source-contains-autogenerated-visual-c++-file
[src/external/u3d/src/RTL/Platform/Win32/IFXCore/IFXResource.h]
N:
P: meshlab source: source-contains-autogenerated-visual-c++-file
[src/external/u3d/src/RTL/Platform/Win32/IFXExporting/IFXResource.h]
N:
P: meshlab source: source-contains-autogenerated-visual-c++-file
[src/external/u3d/src/RTL/Platform/Win32/IFXImporting/IFXResource.h]
N:
P: meshlab source: source-contains-autogenerated-visual-c++-file
[src/external/u3d/src/RTL/Platform/Win32/IFXRendering/IFXResource.h]
N:
P: meshlab source: source-contains-autogenerated-visual-c++-file
[src/external/u3d/src/RTL/Platform/Win32/IFXScheduling/IFXResource.h]
N:
P: meshlab source: source-contains-autogenerated-visual-c++-file
[src/external/u3d/src/RTL/Platform/Win32/IFXShapes/IFXResource.h]
N:
P: meshlab source: source-contains-autogenerated-visual-c++-file
[src/external/u3d/src/RTL/Platform/Win32/IFXTextureModifier/IFXResource.h]
N:
N: Not sure why only these two get the warning, but all are built with the
N: same flags, so considering these false-positives.
O: meshlab: hardening-no-fortify-functions [usr/lib/x86_64-linux-
gnu/meshlab/libmeshlab-common.so]
N:
N: Not sure why only these two get the warning, but all are built with the
N: same flags, so considering these false-positives.
O: meshlab: hardening-no-fortify-functions [usr/lib/x86_64-linux-
gnu/meshlab/plugins/librender_gdp.so]
N:
N: Relative rpath fixes reproducible builds, needed to find private library.
O: meshlab: relative-library-search-path RUNPATH lib/x86_64-linux-gnu/meshlab
[usr/lib/x86_64-linux-gnu/meshlab/libmeshlab-common.so]
N:
N: The binary or shared library sets RPATH or RUNPATH. This overrides the
N: normal library search path, possibly interfering with local policy and
N: causing problems for multilib, among other issues.
N:
N: As an aggravating factor, this search path is relative! It is probably not
N: what you wanted.
N:
N: The only time a binary or shared library in a Debian package should set
N: RPATH or RUNPATH is if it is linked to private shared libraries in the
N: same package. In that case, place those private shared libraries in
N: /usr/lib/*package*. Libraries used by binaries in other packages should be
N: placed in /lib or /usr/lib as appropriate, with a proper SONAME, in which
N: case RPATH/RUNPATH is unnecessary.
N:
N: To fix this problem, look for link lines like:
N:
N: gcc test.o -o test -Wl,--rpath,/usr/local/lib
N:
N: or
N:
N: gcc test.o -o test -R/usr/local/lib
N:
N: and remove the -Wl,--rpath or -R argument.
N:
N: You can also use the chrpath utility to remove the RPATH.
N:
N: Please refer to https://wiki.debian.org/RpathIssue, Bug#732682, and
N: Bug#732674 for details.
N:
N: Visibility: error
N: Show-Always: no
N: Check: binaries/rpath
N:
N:
N: False positive: Nothing pre-built here.
O: meshlab source: source-contains-prebuilt-doxygen-documentation [docs/dox/]
N:
N: The source tarball contains prebuilt doxygen documentation. This is
N: usually left by mistake when generating the tarball without first cleaning
N: the source directory. You may want to report this as an upstream bug if
N: there is no sign that this was intended.
N:
N: It is preferable to rebuild documentation directly from source.
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: documentation/doxygen
N:
E: Lintian run failed (runtime error)
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Issue
philwyett@ks-tarkin:~/Development/builder/debian/meshlab-2022.02+dfsg1$ uscan -
-force-download
Newest version of meshlab on remote site is 2023.12, local version is 2022.02
(mangled local version is 2022.02)
=> Newer package available from:
=>
https://api.github.com/repos/cnr-isti-vclab/meshlab/tarball/refs/tags/MeshLab-2023.12
uscan warn: Parameter ../MeshLab-2023.12 does not have a file extension,
guessed a tarball compressed with gzip.
uscan warn: No files matched excluded pattern as the last matching glob:
scripts/Linux/resources/appimagetool
uscan warn: No files matched excluded pattern as the last matching glob:
scripts/Linux/resources/linuxdeployqt
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/glew-2.1.0
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/lib3ds-1.3.0
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/muparser_v225
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/OpenCTM-1.0.3
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/openkinect
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/qhull-2020.2
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/u3d/Docs/U3D.chm
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/u3d/src/RTL/Dependencies/jpeg
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/u3d/src/RTL/Dependencies/png
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/u3d/src/RTL/Dependencies/zlib
uscan warn: No files matched excluded pattern as the last matching glob:
src/external/xerces
uscan warn: No files matched excluded pattern as the last matching glob:
src/vcglib/apps
uscan warn: No files matched excluded pattern as the last matching glob:
src/vcglib/eigenlib
uscan warn: No files matched excluded pattern as the last matching glob:
src/vcglib/wrap/gcache/docs/css
uscan warn: No files matched excluded pattern as the last matching glob:
src/vcglib/wrap/gcache/docs/js
uscan warn: No files matched excluded pattern as the last matching glob:
src/vcglib/wrap/system/time
Successfully repacked ../MeshLab-2023.12 as
../meshlab_2023.12~DO_NOT_USE_THIS.orig.tar.xz, deleting 3739 files from it.
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Not performed at this time
8. Upgrade [Over previous installs if any]: Not performed at this time
<REPLACE_WITH_SUMMARY>
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc, *.changes,
*.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
Donations...
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Liberapay: https://liberapay.com/kathenas
--
"I play the game for the game’s own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Wiki: https://wiki.kathenas.org
Instagram: https://instagram.com/kathenasorg
Threads: https://www.threads.net/@kathenasorg
--
Attachment:
signature.asc
Description: This is a digitally signed message part