Hi Phil, Thank you for taking the time to review this package. On 8/10/24 10:02 AM, Phil Wyett wrote:
Control: tags -1 +confirmed
Akash,
Preamble...
Thank you for taking the time to prepare this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information, non blocking
The first I would certainly have upstream look at.
I: acr: bash-term-in-posix-shell '((${S}COUNT+1))' [usr/bin/acr-sh:2020]
N:
N: This script is marked as running under /bin/sh, but it seems to use a
N: feature found in bash but not in the SUSv3 or POSIX shell specification.
N:
N: Some examples are:
N:
N: - == in a test, it should use = instead - read without a variable in the
N: argument - function to define a function - source instead of . - .
command
N: args, passing arguments to commands via source is not supported -
N: {foo,bar} instead of foo bar - [[ test ]] instead of [ test ] (requires
a
N: Korn shell) - type instead of which or command -v
N:
N: Visibility: info
N: Show-Always: no
N: Check: shell/non-posix/bash-centric
I: acr source: superficial-tests [debian/tests/control]
N:
N: The source package declares tests in the debian/tests/control file but
N: provides only tests with a superficial restriction.
N:
N: Please provide more meaningful tests.
N:
N: Please refer to
N: https://lists.debian.org/debian-devel-announce/2019/08/msg00003.html,
N: Bug#932870, and
N:
https://salsa.debian.org/ci-team/autopkgtest/tree/master/doc/README.package-tests.rst
N: for details.
N:
N: Visibility: info
N: Show-Always: no
N: Check: testsuite
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: Good
Summary...
I believe acr is ready for sponsorship/upload. Could a Debian Developer (DD)
with available free time, please review this package and upload if you feel
it is ready.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc -t
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
-- Akash Doppalapudi
Attachment:
OpenPGP_0xBCBCAE31ECE05007.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature