[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1017071: marked as done (RFS: psi-notify/1.3.1-1 -- Alert when your machine is becoming oversaturated)

Your message dated Sat, 13 Aug 2022 11:14:13 +0800
with message-id <50d0a0c24546d889b348bb70b9db5b944aea1608.camel@debian.org>
and subject line Re: Bug#1017071: RFS: psi-notify/1.3.1-1 -- Alert when your machine is becoming oversaturated
has caused the Debian Bug report #1017071,
regarding RFS: psi-notify/1.3.1-1 -- Alert when your machine is becoming oversaturated
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
1017071: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1017071
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "psi-notify":

 * Package name    : psi-notify
   Version         : 1.3.1-1
   Upstream Author : Chris Down <chris@chrisdown.name>
 * URL             : https://github.com/cdown/psi-notify
 * License         : Expat
 * Vcs             : https://salsa.debian.org/michel/psi-notify
   Section         : utils

The source builds the following binary packages:

  psi-notify - Alert when your machine is becoming oversaturated

To access further information about this package, please visit the following URL:

  https://mentors.debian.net/package/psi-notify/

Alternatively, you can download the package with 'dget' using this command:

  dget -x https://mentors.debian.net/debian/pool/main/p/psi-notify/psi-notify_1.3.1-1.dsc

Changes since the last upload:

 psi-notify (1.3.1-1) unstable; urgency=low
 .
   * Update to 1.3.1
   * Patches now upstreamed
   * Allows running tests on systems with PSI disabled
   * manpage now included

Regards,

-- 
Michel Alexandre Salim
identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2

Attachment: signature.asc
Description: PGP signature


--- End Message ---
--- Begin Message --- 
On Fri, 2022-08-12 at 16:48 -0500, Michel Alexandre Salim wrote:

>  psi-notify (1.3.1-1) unstable; urgency=low
>  .
>    * Update to 1.3.1
>    * Patches now upstreamed
>    * Allows running tests on systems with PSI disabled
>    * manpage now included

Uploaded, further thoughts:

It is probably not simple/possible to add a proper autopkgtest for
psi-notify, but maybe a superficial one could be added just testing
that the --help option continues to work? This would ensure that the
binary can at least be run after it has been built.

When I do DEB_BUILD_OPTIONS=noopt, the -02 option still appears in gcc
command-lines along with the -O0 option.

In future, please document all changes in debian/changelog,
the CPPFLAGS and ASan patches weren't mentioned.

In the CPPFLAGS patch, does this do anything or is it a no-op?

   CPPFLAGS:=$(CPPFLAGS)

I wonder if upstream could be convinced to just use the make implicit
rules rather than reimplementing them.

Please note that the toolchain sanitization feature is not intended for
use in production binaries and can introduce security issues, so please
do not ever enable it for the main binary.

https://www.openwall.com/lists/oss-security/2016/02/17/9

Most of the comments in debian/salsa-ci.yml look unnecessary.

I think that the debian/upstream/metadata file has used the
Other-References field incorrectly, I think it should be a
Documentation field instead and also link the Facebook docs.

I suggest that the upstream manual page should also link to the
official Linux kernel documentation about the PSI feature.

https://www.kernel.org/doc/html/latest/accounting/psi.html

I can't find the git repo for the Facebook PSI documentation.

Since the Facebook PSI documentation is more comprehensive than the
Linux kernel version of it, I think it would be useful to have the
former available in Debian in a separate package for offline use.

Or possibly Facebook should forward their PSI docs upstream to Linux :)

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
Reply to: