Bug#987181: RFS: cpufetch/0.97-1 -- Simple yet fancy CPU architecture fetching tool

[clay stan <claystan97@gmail.com>]

Tobias Frost <tobi@debian.org> 于2021年6月3日周四 上午1:33写道：
>
> Control: tags -1 moreinfo
>
> Hi Clay,
>
> here's a review:
> - The patch: The dep3 header, the field Bug-Debian is wrong, the ITP is not
>   related to the patch

Thanks, I've updated.

> - The patch looks strange to me: Why do you patch the Makefile? What do you
>   want to archieve? Parts of the patching seems ok (like avoiding stomping over
> CFLAGS, but other parts seems excessive, removing sane parts to me…

The original compilation parameters will also cause Lintian to report errors,
hardening no bind now, hardening no mandatory functions.
I'll try to solve them in debian/rules by
https://wiki.debian.org/Hardening, but it doesn't work

and the sane parts, you mean?

>   - Upstream seems to support arm, you patch that out?

Upstream support arm means the mobile arm chips, like Snapdragon, MediaTek,
not arm PC, They are not supported by Debian.

>   - There is no LDCFLAGS -> did you mean LDFLAGS?

Yeah, I've updated. Thanks again.

>
> - (not a blocker) Please send the manpage upstream for inclusion.
>
>
> Waiting for your reply…
>
> Cheers,
> tobi
>