Bug#987181: RFS: cpufetch/0.97-1 -- Simple yet fancy CPU architecture fetching tool
Control: tags -1 moreinfo
Hi Clay,
here's a review:
- The patch: The dep3 header, the field Bug-Debian is wrong, the ITP is not
related to the patch
- The patch looks strange to me: Why do you patch the Makefile? What do you
want to archieve? Parts of the patching seems ok (like avoiding stomping over
CFLAGS, but other parts seems excessive, removing sane parts to me…
- Upstream seems to support arm, you patch that out?
- There is no LDCFLAGS -> did you mean LDFLAGS?
- (not a blocker) Please send the manpage upstream for inclusion.
Waiting for your reply…
Cheers,
tobi
Reply to: