On Wed, 2020-07-08 at 20:09 +0300, Boian Bonev wrote: > Checking further I see that in order to enable this protection, a -Wl,- > z,now needs to be added to LDFLAGS and dpkg-buildflags does not include > it (at least on my sid install). For the sake of test, I have added it > in Makefile and the warning have disappeared. I do not think that this > should be fixed in the package - that option should come from dpkg- > buildflags. As gregor mentioned, this needs enabling in debian/rules. > That is perfectly safe - all recent (last 20 years) glibc versions > allow passing NULL for %s and print (null)... Anyways it is better to > check it explicitly and spare some time for the people who are going to > look into that some day. In theory iotop-c could be used on non-glibc platforms like Alpine Linux, but perhaps musl has the same protections? I guess there are other embedded libcs that don't do that though. Either way being explicit is indeed better. > I do not get that - the current Makefile uses GNU make extensions and > wildcards, but not a single implicit rule. Please clarify which part > can be improved. I mean you could delete the commands that specify how to build .o files and build iotop and rely on the built-in rules. It might not be worth the effort to figure out how to do this though, especially considering the portability concerns. https://www.gnu.org/software/make/manual/html_node/Using-Implicit.html#Using-Implicit https://www.gnu.org/software/make/manual/html_node/Catalogue-of-Rules.html#Catalogue-of-Rules > I think this is the only way, in case there is a system with this > package and older iotop package, the only way to prevent installing > files in the same place is conflicts. Maybe it would be nice if there > was a way to tell lintian to silence the warning... OK, please do check if Breaks works or not if you haven't already. So install an old version of iotop py on bullseye and then apt install ./iotop-c_*.deb with both Conflicts and Breaks and see what happens. > There is no signature upstream, can't fix that too. If you have an OpenPGP key you could do signing. -- bye, pabs https://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part