On Wed, 08 Jul 2020 20:09:03 +0300, Boian Bonev wrote: > Checking further I see that in order to enable this protection, a -Wl,- > z,now needs to be added to LDFLAGS and dpkg-buildflags does not include > it (at least on my sid install). For the sake of test, I have added it > in Makefile and the warning have disappeared. I do not think that this > should be fixed in the package - that option should come from dpkg- > buildflags. It's not enabled by default, but you can add export DEB_BUILD_MAINT_OPTIONS = hardening=+bindnow to debian/rules to add the flag. Cf. dpkg-buildflags(1) > > Please fix any of the easy-to-fix lintian complaints. I'm not sure > > what is correct for the conflicts, but you could test using piuparts > > if using breaks is enough or if using conflicts is really needed. I > > assume you'll want to keep debhelper compat 12 for backportability. > > Look up the tag names on lintian.d.o or using `lintian-info -t` for > > descriptions of the tags. > > > > I: iotop-c: conflicts-with-version iotop (<= 0.6-24-g733f3f8-1) > > I think this is the only way, in case there is a system with this > package and older iotop package, the only way to prevent installing > files in the same place is conflicts. Maybe it would be nice if there > was a way to tell lintian to silence the warning... There is a way, it's called "lintian overrides" :) Cf. file:///usr/share/doc/lintian/lintian.html#overrides But I guess in this case a Breaks would be more appropriate than a Conflicts. Cf. 7.3 and 7.4 in Debian Policy https://www.debian.org/doc/debian-policy/ch-relationships.html#packages-which-break-other-packages-breaks ff. > > I: iotop-c source: testsuite-autopkgtest-missing > Can't fix that. Well, you could write an autopkgtest :) Cf. https://ci.debian.net/doc/file.MAINTAINERS.html , https://salsa.debian.org/ci-team/autopkgtest/raw/master/doc/README.package-tests.rst etc. (But IMO that's not required for a first upload.) Cheers, gregor -- .''`. https://info.comodo.priv.at -- Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe `-
Attachment:
signature.asc
Description: Digital Signature