[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#929467: RFS: tfortune-1.0.0 [ITP]



On Wed, Jun 19, 2019 at 11:45:08AM +0200, Andre Noll wrote:
> On Tue, Jun 18, 17:48, Adam Borowski wrote
> > Looks good.
> > 
> > However, version 1.0.0-1 is already in NEW, thus unless it's REJECTed, the
> > version number cannot be reused.
> > 
> > There's also a typo: "considerd".
> 
> Thanks for the review.
> 
> Both issues have been fixed in v2 of the t/tfortunes branch which
> I've just pushed out.  This branch also contains two new commits
> which fix a gcc warning and a harmless memory leak.

Uploaded, with some changes.

> PS: I shall be offline until next Tuesday.

To skip the wait, I applied some fixes myself.  They are: a bogus
day-of-week (which our tools detect and complain about) and the data package
not being Arch:all.  Here's the diff:

diff --git a/debian/changelog b/debian/changelog
index e27a3d0..7b31b5f 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -3,7 +3,7 @@ tfortune (1.0.0-2) unstable; urgency=low
   * Fallback to system-wide epigram directory.
   * New data package: "tfortunes" which contains ~200 epigrams.
 
- -- Andre Noll <maan@tuebingen.mpg.de>  Mon, 18 Jun 2019 18:33:25 +0100
+ -- Andre Noll <maan@tuebingen.mpg.de>  Tue, 18 Jun 2019 18:33:25 +0100
 
 tfortune (1.0.0-1) unstable; urgency=low
 
diff --git a/debian/control b/debian/control
index f28abb1..4981f4a 100644
--- a/debian/control
+++ b/debian/control
@@ -24,7 +24,8 @@ Description: Fortune Cookies with Tags
  only.
 
 Package: tfortunes
-Architecture: any
+Architecture: all
+Multi-Arch: foreign
 Depends: tfortune, ${misc:Depends}
 Description: Data files for tfortune
  This provides a small set of tagged epigrams for tfortune. These are


Meow!
-- 
⢀⣴⠾⠻⢶⣦⠀
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ Have you accepted Khorne as your lord and saviour?
⠈⠳⣄⠀⠀⠀⠀


Reply to: