[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#929467: RFS: tfortune-1.0.0 [ITP]



Hi,

Le 01/06/2019 à 13:36, Andre Noll a écrit :> On Fri, May 31, 17:32, Adam
Borowski wrote
>> On Fri, May 24, 2019 at 08:57:49AM +0200, Andre Noll wrote:
>>>  * Package name    : tfortune
>>>    Version         : 1.0.0
>>
>>> 	git clone git://git.tuebingen.mpg.de/tfortune/
>>
>> Hi!
>> I'm afraid your packaging unnecessarily reinvents a good part of usual
>> tools, and does this wrong.  For example:
>> * directories have non-standard permissions, and this affects common
dirs as
>>   well
>
> Oops, this was indeed broken. Should be fixed now.
>
I think Adam meant to not implement low level makefile targets yourself,
but use dh like this:
```
#!/usr/bin/make -f

export DEB_BUILD_MAINT_OPTIONS = hardening=+all
%:
        dh $@

override_dh_auto_configure:
        dh_auto_configure -- \
          --bindir=\$${prefix}/games \
          --datadir=\$${prefix}/share/games
```

Every low level targets are handled by dh and you can override some of
them using `override_dh_*`.
Here override_dh_auto_configure override the configure step to use game
specific directories. This is what is done for the warzone2100 game package.

Actually, this simple debian/rules file above will work and let dh
handle all issues about md5, permissions, hardening CFLAGS and maybe
make the build reproducible too.

-- 
Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC  2787 E7BD 1904 F480 937F

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: