On Fri, May 31, 17:32, Adam Borowski wrote > On Fri, May 24, 2019 at 08:57:49AM +0200, Andre Noll wrote: > > * Package name : tfortune > > Version : 1.0.0 > > > git clone git://git.tuebingen.mpg.de/tfortune/ > > Hi! > I'm afraid your packaging unnecessarily reinvents a good part of usual > tools, and does this wrong. For example: > * directories have non-standard permissions, and this affects common dirs as > well Oops, this was indeed broken. Should be fixed now. > * gzip is invoked without -n, which renders the package non-reproducible That was also easy enough to fix. I've added -n to both gzip commands. > * standard build flags don't get passed to the compiler Can you elaborate this concern? The Makefile does add $(CPPFLAGS) and $(CFLAGS) to the cc command and $(LDFLAGS) to the linker command. Which standard build flags don't get passed? > * no md5sum files are generated Fixed. I've pushed out v2 of the t/debian branch, which addresses all concerns except the one about the build flags. Would you please have another look? Thanks for your feedback Andre -- Max Planck Institute for Developmental Biology Max-Planck-Ring 5, 72076 Tübingen, Germany. Phone: (+49) 7071 601 829 http://people.tuebingen.mpg.de/maan/
Attachment:
signature.asc
Description: PGP signature