Bug#904028: RFS: freetype/2.9.1-0.1 [NMU]
Control: tag -1 -moreinfo
Hi Mattia,
Thank you for your review. Please see my responses to your review below.
I've also uploaded a new version to Mentors. And a reminder, since this version
adds a new package, the upload will need to go through the NEW queue.
On Friday, 20 July 2018 10:55 PM +1000, Mattia Rizzolo wrote:
> * please let's upload this to experimental. If anything to check it
> actually builds everywhere… We can upload a -0.2 to unstable few days
> after it lands to experimental
Yes, agreed. This is sensible, given that freetype-config is no longer packaged.
> * the version on the gettext build-dep can go away
Done.
> * why did you remove the alternative dependency 'libc6-dev | libc-dev'?
> the changelog doesn't mention this change, and it doesn't look so
> correct to me; if somebody took the time to explicit a dependency on
> libc-dev there is probably a good reason… (same for libz-dev)
Sorry, I thought we only needed one, because libc6-dev provides libc-dev.
I've reverted this change for both libc6-dev and libz-dev.
> * freetype2-demos lost its ${shlibs:Depends}? (also undocumented)
> - and indeed it seems the built package has no dependencies.
This was my fault. I was only installing wrapper scripts, not the actual binaries.
Fixed in the new version.
> * you moved away from dh_installdocs --link-doc. I personally like it,
> because it can be source of many pitfalls, like this case: moving from
> symlinks to directories requires using dpkg-maintscript-helper's
> symlink-to-dir... however I'm conflicted on whether this is a change
> you should do in a NMU (but then, considering the already huge
> changelog…).
I've added symlink_to_dir maintscripts for freetype2-demos and
libfreetype6-dev, as well as the dpkg pre-depends field.
> * /usr/bin/freetype-config is not a thing anymore, are rdeps fine?
> Also, this something I'd mention in the changelog as well.
Reverse build-dependencies are progressively being fixed. I'm using a usertag
'freetype-config' to track this.
I will also email the remaining bugs to alert the package maintainers of the
availability of the experimental version.
> Thank you for the really thorough update, forwarding years-old patches
> upstream, etc, very nice! :)
Thank you!
--
Hugh McMaster
Reply to: