Control: owner -1 !
Control: tag -1 moreinfo
On Wed, Jul 18, 2018 at 01:40:15PM +0000, Hugh McMaster wrote:
> I am looking for a sponsor for an NMU of the package "freetype".
o/
> dget -x https://mentors.debian.net/debian/pool/main/f/freetype/freetype_2.9.1-0.1.dsc
So, you made many (long overdue, IMHO) changes. Given that this is
still an NMU I'll stop my review to the debdiff from the version
currently in the archive.
* please let's upload this to experimental. If anything to check it
actually builds everywhere… We can upload a -0.2 to unstable few days
after it lands to experimental
* the version on the gettext build-dep can go away
* why did you remove the alternative dependency 'libc6-dev | libc-dev'?
the changelog doesn't mention this change, and it doesn't look so
correct to me; if somebody took the time to explicit a dependency on
libc-dev there is probably a good reason… (same for libz-dev)
* freetype2-demos lost its ${shlibs:Depends}? (also undocumented)
- and indeed it seems the built package has no dependencies.
* you moved away from dh_installdocs --link-doc. I personally like it,
because it can be source of many pitfalls, like this case: moving from
symlinks to directories requires using dpkg-maintscript-helper's
symlink-to-dir... however I'm conflicted on whether this is a change
you should do in a NMU (but then, considering the already huge
changelog…).
* /usr/bin/freetype-config is not a thing anymore, are rdeps fine?
Also, this something I'd mention in the changelog as well.
Thank you for the really thorough update, forwarding years-old patches
upstream, etc, very nice! :)
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature