[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#903270: RFS: sharness/1.0.0-1 [ITP] shell library for running tests



Hello Sergio,

thank you for reviewing my packaging attempt!


Am Wed, 11 Jul 2018 23:21:05 -0400
schrieb Sergio Durigan Junior <sergiodj@debian.org>:

> [..]
> 1) On d/copyright, you don't list the files under the "debian/"
> directory.  These should be listed, and you should be the author.  I
> recommend choosing the same license as upstream, just to make things
> simpler.
>
> 2) On d/control, Standards-Version should now be 4.1.5.
> 
> 3) Better safe than sorry: on d/control, the Vcs-* fields should point
> to your salsa.d.o repo.

Done (1-3).


> 4) On d/rules, you can remove the "override_dh_auto_install" target if
> you're not using it.

Done.
I am a bit embarrassed, that I overlooked that cruft ...


My recent upload contains another change besides the ones above: for now I
removed the helper script "aggregate-results.sh".
I started a discussion with upstream in order to decide whether that file needs
to be included at all (https://github.com/chriscool/sharness/issues/78).


> Otherwise, the package looks good to me.  Let me know when you address
> these issues and I'll be happy to upload it.

Thank you for your kind offer!
I just uploaded my updated source package:
 https://mentors.debian.net/debian/pool/main/s/sharness/sharness_1.0.0-1.dsc

Cheers,
Lars


Reply to: