[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#903270: RFS: sharness/1.0.0-1 [ITP] shell library for running tests



Control: owner -1 !
Control: tags -1 + moreinfo

On Sunday, July 08 2018, Lars Kruse wrote:

> Dear mentors,

Hi Lars,

> I am looking for a sponsor for my package "sharness"
>
>  Package name    : sharness
>  Version         : 1.0.0-1
>  Upstream Author : Christian Couder <chriscool@tuxfamily.org>
>  URL             : https://github.com/chriscool/sharness
>  License         : GPL-2 or later
>  Section         : devel
>
> It builds those binary packages:
>
>   sharness   - shell library for automated tests with TAP output
>
> Sharness is used by a few Debian packages as part of their DEP8 tests
> (via autopkgtest):
>   * gearmand
>   * git-reintegrate
>   * git-remote-bzr
>   * git-remote-hg
>   * hiera-eyaml
>   * jemalloc
>   * mod-gearman
>   * munin
>   * pass-otp
>   * puppet-lint
>   * puppet-module-puppetlabs-concat
>   * puppet-module-puppetlabs-ntp
>   * puppet-module-puppetlabs-stdlib
> (the list was assembled via https://codesearch.debian.net)
>
> Currently these packages embed a copy of the sharness.sh file below
> debian/tests.
> I will file bug reports against these packages (including patches) after
> the sharness package is available, in order to help them getting rid of
> their embedded code copies.

Thanks, that is a nice goal.

> I am part of the munin packaging team, thus the munin package would
> benefit immediately from this new package.
>
> I plan to maintain the sharness package for the foreseeable future.

We had a brief conversation on IRC, where I told you that this package
should be hosted at salsa.d.o.  You told me you created a new repo
there.  Great!

Here are the other things I noticed about the package.  Mostly nits.  I
think we should be good to go once you address them.

1) On d/copyright, you don't list the files under the "debian/"
directory.  These should be listed, and you should be the author.  I
recommend choosing the same license as upstream, just to make things
simpler.

2) On d/control, Standards-Version should now be 4.1.5.

3) Better safe than sorry: on d/control, the Vcs-* fields should point
to your salsa.d.o repo.

4) On d/rules, you can remove the "override_dh_auto_install" target if
you're not using it.

Otherwise, the package looks good to me.  Let me know when you address
these issues and I'll be happy to upload it.

Thanks!

-- 
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF  31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/

Attachment: signature.asc
Description: PGP signature


Reply to: