Bug#862940: RFS: slick-greeter/1.0.3-1 ITP
On Wed, May 24, 2017 at 06:57:17PM +0100, foss.freedom wrote:
> I have switched liblightdm-gobject-1-dev and liblightdm-gobject-dev
> around in the latest upload. Hopefully this will resolve the first
> alternate rule on buildds
Builds and runs fine, thanks!
The package is in a shape fit for unstable now; let's continue with review
but you can choose whether you prefer to get it into NEW then do incremental
improvements, or to fix the issues immediately.
* the fonts looks ugly. I see you want to use fonts-cantarell but don't
actually depend on it; since it's configurable, a Suggests: or Recommends:
stanza would be appropriate.
* the README talks about /etc/lightdm/slick-greeter.conf -- yet it 1. is not
shipped with the package and 2. there's not a word of documentation about
what can you put in that file and what is its syntax. I'd recommend
installing such a file with commented out possible settings.
* it talks about a configurator, "lightdm-settings". I assume someone will
package it in nearby future, right?
Meow!
--
Don't be racist. White, amber or black, all beers should be judged based
solely on their merits. Heck, even if occasionally a cider applies for a
beer's job, why not?
On the other hand, corpo lager is not a race.
Reply to: