[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#832941: RFS: 4pane



Dear Sean,

>Hopefully a final review (of b74e630):

>- your copyright on debian/ is out-of-date -- you need s/2016/2017/
>By the way, you can merge the '*' and 'debian/*' stanzas.

Done

>- Various stanzas do not include the copyright years, yet these are
>  available in the files.  The Copyright: field is meant to contain the
>  copyright claim as it was stated by the upstream author..

May I ask which tool you used for that? I've found debmake -kk the best I've
tried, but it doesn't check for dates.

I've gone through by hand and added all that I found.

>- Files in .build/ remain, and are not given in d/copyright.

The remaining ones are my own files. Won't they be covered by '*'?

>- Makefile.in is still in the tarball, but it's not in the preferred
>  format for modification, as we've discussed previously.  It has to be
>  removed.

I'll do so, but not yet in case I need to remove any of the following too.

>- Files: bitmaps/iceweasel.png
>  Copyright: Uncertain
>
>Files: bitmaps/kedit.xpm
>Copyright: Unknown
>
>Files: bitmaps/kwrite.xpm
>Copyright: Various
>
>The ftp-masters would be very likely to reject these.  Since you found
>the source repos, surely you can find a name for the copyright fields?

I tried hard, but failed to find definite copyright authors for these and
other bitmaps; I therefore added 'Comment:' fields. In detail:

iceweasel.png:
I'd originally put in the 'Comment' field: "See
https://addons.mozilla.org/en-gb/firefox/addon/iceweasel-branding/ which says:
"Original copyright 2005-2014, Mike Hommey The artwork is copyright Unicko". I
was wrong to suggest CC-BY-SA; I think that is just the license of the add-on
page. The iceweasel-branding package has the same icon:
https://anonscm.debian.org/cgit/pkg-mozext/iceweasel-branding.git/plain/src/iceweasel/iceweasel_icon.svg.
That package's d/copyright
(http://metadata.ftp-master.debian.org/changelogs/main/f/firefox-branding-iceweasel/firefox-branding-iceweasel_0.4.0_copyright)
doesn't specify a separate license for the .svg icon. Globally it says: 
"src/iceweasel/* Copyright: 2005-2014, Mike Hommey <glandium@debian.org>
1998-2010, Mozilla Project 2016 Desktopd Project License: MPL-2.0"
so I've changed it to that, minus the 2016 entry as I copied the icon in 2008.

kedit.xpm and kwrite.xpm. I added these icons in 2003 or 4, probably from SuSE
8.2 which I was using at the time. According to
https://github.com/KDE/kde1-kdeutils/commit/fe8e268ff0d795017227f40b6137006a6cbc2e09
these icons were amoung those added to kdeutils in 1999 by Torsten Rahn with
the comment "Painted by the kde-artist team". No copyright is mentioned there.
Though grepping the package shows that some of its constituents, e.g. konsole,
have separate licence files, neither kedit nor kwrite do. kdeutils itself has a
GPL-2 'COPYING' file. It also has a debian; d/copyright says "Copyright: All
programs are either under the GPL or the Artistic License (namely kpanel, kwm,
konsole, kstart)".

I can find no further information about kedit.xpm. If you feel that's
sufficient to specify GPL-2, copyright Torsten Rahn 1999, I'll do so. Otherwise
I don't know what is correct. Should I remove this icon from the package? 

kwrite is still maintained, associated with kate.
http://metadata.ftp-master.debian.org/changelogs/main/k/kate/kate_4.8.4-1_copyright,
dated 2012, says about kwrite itself: kwrite/ Copyright: © 2010 Dominik Haumann
<dhaumann kde org> Copyright: © 2001 Christoph Cullmann <cullmann@kde.org>
Copyright: © 2001 Joseph Wenninger <jowenn@kde.org> Copyright: © 2001 Anders
Lund <anders.lund@lund.tdcadsl.dk> License for all components unless stated
otherwise: GNU Library General Public License, version 2 (LGPL-2)

Again I'm happy to use that specific attribution if you consider it will
apply to the xpm too.

I also put 'various' for mate-text-editor.png, gedit.xpm and evince.xpm, for
similar reasons.
mate-text-editor.png:
https://github.com/perberos/mate-text-editor/blob/master/AUTHORS gives 10 names
but doesn't mention the icon specifically.

gedit.xpm:
For gedit itself
http://metadata.ftp-master.debian.org/changelogs/main/g/gedit/gedit_3.22.0-2_copyright
lists 30 copyright owners, with various dates. There is no mention of the
icon's creator or specific copyright.

evince.xpm:
http://metadata.ftp-master.debian.org/changelogs/main/e/evince/evince_2.30.3-2+squeeze1_copyright
mentioned 9 authors in 2005. Cloning git.gnome.org/evince makes it clear that
evince itself is GPL-2 but doesn't mention the icon's author or separate
copyright.

bitmaps/include/chardevice.xpm bitmaps/include/blockdevice.xpm:
These are in kde1-kdebase.
https://github.com/KDE/kde1-kdebase/blob/master/COPYING confirms the licence is
GPL-2. https://github.com/KDE/kde1-kdebase/blob/master/AUTHORS says: "Look in
the subdirs to get info about the authors. The package is maintained by Stephan
Kulow <coolo@kde.org>" However the xpms aren't in a particular app's subdir,
they're in pics/ together with many others and have no separate copyright or
author files.

With the possible exception of kedit, all of these icons are or were included in
other debian packages, so it would be surprising if there is no solution short
of removal. In general, what currently acceptable ways are there to fill the
Copyright field when an author isn't specified for a particular element of a
package?

Finally, my ITP has timed-out and the package removed from mentors. Does this
now matter?

Regards,

David Hart


Reply to: