[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#832941: RFS: 4pane



Dear David,

Hopefully a final review (of b74e630):

- you forgot `dch -r`

- your copyright on debian/ is out-of-date -- you need s/2016/2017/

By the way, you can merge the '*' and 'debian/*' stanzas.

- Files: bitmaps/iceweasel.png
  Copyright: Uncertain

Files: bitmaps/kedit.xpm
Copyright: Unknown

Files: bitmaps/kwrite.xpm
Copyright: Various

The ftp-masters would be very likely to reject these.  Since you found
the source repos, surely you can find a name for the copyright fields?

- The shortname "CC-BY-SA" should probably be suffixed with the license
  version.

- Makefile.in is still in the tarball, but it's not in the preferred
  format for modification, as we've discussed previously.  It has to be
  removed.

- Various stanzas do not include the copyright years, yet these are
  available in the files.  The Copyright: field is meant to contain the
  copyright claim as it was stated by the upstream author..

- Files in .build/ remain, and are not given in d/copyright.

--
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: