Hi Sean,
On Sun, Jan 15, 2017 at 07:45:18AM -0700, Sean Whitton wrote:
> I found some more errors in the copyright file. Rather than go back and
> forth once again, I fixed them in our team git repository. I set the
> changelog back to UNRELEASED: if you are okay with the changes, please
> `dch -r`, commit and push, and I will upload.
Why did you remove 2001 from Eric Marsen's cgi.el copyright entry when
the file is time stamped <2001-08-24 emarsden>? For httpd.el, I agree
that "2001, 2003" is more accurate, but is it allowed? In the past,
when I've submitted patches to this effect the maintainer of the
package changed the lines to something like "2001-2003", even though
the VCS and copyright embedded in the file specified discreet years
rather than a range...which led me to believe that a discreet range is
unacceptable.
Thank you for the addition of FSF (c) holder, and for adding the final
newline back in. I'm guessing it disappeared as an artefact of a git
rebase. A manual git rm elpa-muse.maintscript was also necessary
(argh).
> > > 3) Eric Marden's copyright on contrib/{cgi.el, httpd.el} is not
> > > reflected in d/copyright.
> >
> > I broke these out into individual stanzas, because I'm short on time
> > right now and wasn't able to find canonical documentation quickly
> > enough. Comma separated or
> > Files: file1
> > file2
> >
> > both seem like likely possibilities. Would it be a nuisance to the
> > maint-guide maintainers if I filed a bug requesting some guidelines on
> > how to group things? Is that the most appropriate package to file a
> > bug against for this issue?
>
> You couldn't find the info in the spec?
>
> https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
Ah! Yes, this is the spec that addresses my question to #3. That
said, in the past some of my other work on d/copyright has been said
to be "worse than useless" even though it adhered to the spec, and
even though it seemed to reflect what I saw reading the packages
COPYING file, in addition to spending a while reading VCS commits for
stuff I wasn't sure about. This has led me to wonder about the tribal
rules that are not in the spec...
Would you please check to see if my latest commit to d/copyright is
ok? It's what makes the most sense to me. As far as I can tell, it
might be problematic because it infers that Eric Marsden changed
cgi.el in 2003. If it's problematic I'll revert it, then dch -r.
> > For some reason my piuparts installation isn't working properly, but
> > manually I tested both clean install and upgrading in a clean sid
> > chroot. (this is how I tested #1 and #6)
>
> piuparts is failing here too, due to issues in the ldap packages. I
> also tested the manual upgrade and it works :)
:-)
Kind regards,
Nicholas
Attachment:
signature.asc
Description: Digital signature