Bug#844184: RFS: muse-el/3.20+dfsg-1 [ITA]

[Nicholas D Steeves <nsteeves@gmail.com>]

Dear Sean,

I think it's finally ready.

On Sat, Dec 31, 2016 at 02:19:27PM +0000, Sean Whitton wrote:

> Thank you for your updated package.  As mentioned previously, we're
> still in time for binNEW.  I've found six remaining issues.  All are
> very easy to fix/check.  Some of these I should have found earlier, so
> my apologies for that.  Some of them are due to your most recent
> changes, though.
> 
> 1) From running adequate:
> 
>     2m48.4s ERROR: FAIL: Inadequate results from running adequate!
>       muse-el: obsolete-conffile /etc/emacs/site-start.d/50muse-el.el

Fixed by adding muse-el.maintscript.  For renamed
packages/transitions, it looks like it needs to be old-name.maintscript.

> 2) "License: MIT" should be "License: Expat".
> 
> "MIT" is ambiguous between various different licenses.

Fixed.

> 3) Eric Marden's copyright on contrib/{cgi.el, httpd.el} is not
> reflected in d/copyright.

I broke these out into individual stanzas, because I'm short on time
right now and wasn't able to find canonical documentation quickly
enough.  Comma separated or
Files: file1
       file2

both seem like likely possibilities.  Would it be a nuisance to the
maint-guide maintainers if I filed a bug requesting some guidelines on
how to group things?  Is that the most appropriate package to file a
bug against for this issue?

> 4) contrib/pyblosxom/make-blog has a custom license.
This one required research.  Fixed.

> 5) COPYING is not copyright the muse-el authors!  By convention, we
> ignore copies of licenses in d/copyright, so you can just remove it.
Thanks for the tip!

> 6) elpa-muse_3.20+dfsg-1_all.deb did not install cleanly.  I pushed a
> commit fixing the problem -- please check it is okay with you.

Back in August, I remember consulting you about what package to source
htmlize from, but forgot that this was the original cause, so yes, I'm
ok with it ;-)

> Don't forget to update the changelog for the above, and `dch -r`.  I
> would recommend testing with piuparts to confirm the (1) and (6) are
> resolved.  I'm confident that I'll be able to upload once you've
> resolved these six points, though I've replied to your other comments
> below.

For some reason my piuparts installation isn't working properly, but
manually I tested both clean install and upgrading in a clean sid
chroot. (this is how I tested #1 and #6)

> > On Sat, Dec 10, 2016 at 02:46:11PM -0700, Sean Whitton wrote:
> > > Dear Nicholas,
> > > 
> > > On Wed, Dec 07, 2016 at 09:16:28PM -0500, Nicholas D Steeves wrote:
[...]
> > > 4. "- Change section to editors; Change priority to optional."
> > > 
> > > This should be two separate lines.
> > 
> > Notice of this kind of convention I'd like to see in a "New Packages
> > Guide" ;-)
> 
> This should probably be in maint-guide.  You could file a bug if there
> is no mention there.  The idea is simply that each '*' is a separate
> change.

Bug filed!

Thanks again for the help!
Nicholas