[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#850678: marked as done (RFS: gnome-shell-extension-show-ip/4.0.1-2 [ITP])

Your message dated Wed, 11 Jan 2017 15:21:58 +0100
with message-id <20170111142158.GA27739@fatal.se>
and subject line Re: RFS: gnome-shell-extension-show-ip/4.0.1-1 [ITP]
has caused the Debian Bug report #850678,
regarding RFS: gnome-shell-extension-show-ip/4.0.1-2 [ITP]
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
850678: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=850678
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "gnome-shell-extension-show-ip"

* Package name    : gnome-shell-extension-show-ip
  Version         : 4.0.1-1
  Upstream Author : Kyle Robbertze <kyle@aims.ac.za>
* URL             :
https://gitlab.com/paddatrapper/show-ip-gnome-extension
* License         : GPL-3+
  Section         : gnome

It builds these binary packages:

  gnome-shell-extension-show-ip - Shows the current private or public IP
address

To access further information about this package, please visit the
following URL:

https://mentors.debian.net/package/gnome-shell-extension-show-ip

Alternatively, one can download the package with dget using this command:

  dget -x
https://mentors.debian.net/debian/pool/main/g/gnome-shell-extension-show-ip/gnome-shell-extension-show-ip_4.0.1-1.dsc

More information about gnome-shell-extension-show-ip can be obtained
from https://gitlab.com/paddatrapper/show-ip-gnome-extension

Changes since the last upload:

gnome-shell-extension-show-ip (4.0.1-1) unstable; urgency=medium

  * Initial release (Closes: #850672)

 -- Kyle Robbertze <krobbertze@gmail.com>  Mon, 09 Jan 2017 09:42:24 +0200

Regards,
 Kyle Robbertze

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message --- 
Hi Kyle Robbertze,

On Tue, Jan 10, 2017 at 09:43:07PM +0200, Kyle Robbertze wrote:
> Hi Andreas Henriksson,
> 
> On 10/01/2017 15:36, Andreas Henriksson wrote:
> > Hello Kyle Robbertze,
> > 
> > [...]
> > In my personal opinion it's your choice to "upgrade" to the later version
> > but in my experience the ftp-masters expect you to document the original
> > licensing offer made by upstream in debian/copyright.
> > (So if you actually intend to upgrade the version of the license
> > you likely atleast need to state this explicitly so it's obvious
> > when it gets reviewed. I assume it's a simple mistake on your side
> > though and you intended to use the same license as upstream.)
> I licensed it under the GPLv3+, because, while src/extension.js is

... and src/prefs.js  is also GPLv2+ ...

> licensed under the GPLv2+, the rest according to the LICENSE file is
> under the GPLv3+. Should I rather add the src/extension.js exception?

Indeed LICENSE file is GPLv3 which I find peculiar.

The extension is basically made up of:
src/convenience.js: BSD (3 clause)
src/extension.js: GPL (v2 or later)
src/prefs.js: GPL (v2 or later)

Other files like schemas, json, etc. are likely not copyrightable at all,
but what do I know.

You might want to ask your upstream to clarify the licensing situation.

For now documenting the overall license to be GPLv3+ is probably ok,
but I think ftp-masters might say you should still document the
src/extension.js and src/prefs.js as GPLv2+ though.

Lets upload and see what they say... be prepared for possibly a reject.

Apart from that I can't really spot any real issues with your package.

One advice though would be to make install.sh reusable via DESTDIR
and use it from debian/rules instead of duplicating install.sh
in debian/rules. Basically replace DEST=... in install.sh
with:
if [ -z "$DESTDIR" ]; then
	DESTDIR=~/.local/..../$NAME
else
	DESTDIR="$DESTDIR/$NAME"
fi

You might also want to add -p to your mkdir call.

Then call it like this from debian/rules:

DESTDIR=debian/tmp/usr/share/...../extensions ./install.sh local-install

This means you can also drop debian/*install etc.

Just a suggestion.

Anyway, uploaded.

Regards,
Andreas Henriksson

--- End Message ---
Reply to: