Bug#849918: RFS: tinymux/2.10.1.13-1
Control: tags -1 moreinfo
Am Mittwoch, den 04.01.2017, 20:15 -0700 schrieb Stephen Dennis:
> Thanks for the starting point. I had worked out the d/watch file
> enough
> that it works locally (mentors.debian.net still complains), but I
> like your
> wildcards better, so I'm using that one (mentors.debian.net still
> complains).
It could be that mentors has an older uscan which does not yet
understand version=4.
Please note that my version is not perfect, but I'd also would have to
ask to make it so (e.g on #debian-mentors): As your layout on your
server is complicated, the current file cannot properly dectect future
version, like a 2.12... (E.g the directory depth differs and also once
uscan detected the 2.12 directory it won't look into the 2.10 anymore,
because I guess you want the alpha not listed as new version.)
Maybe you can bring your example on #debian-mentors if there is an
solution. (Not needed for this sponsoring)
(You can also utilize the fact that you're upstream and easethings by
placing a link on your homepage which can more easily consumed by
uscan.
BTW, you're using the tar.gz .. Can you use the tar.bz2 for the
packaging as it compresses better? This is also the one that is picked
up by uscan... (Just use uscan --force-download to get a copy and then
delete the other one)
> The simple short d/rules is very much appreciated. I only just
> begin to discover the override_* stuff before you sent it. You saved
> me two
> days there. That and writing d/install and d/clean exposed some
> embarrassing stray symbolic links. I actually prefer enumerating the
> exact
> placement of all the files. So, what remains:
Thanks for looking into it.
remarks:
- d/clean: You can use wildcards, eg. it is less fragile if your clean
games/bin/* instead of the individual files.
- you do not need to d/clean condig.(log|status)
About the install:
- there are a few files with *.conf that are going to /usr/share/...
Are they conf-files that should actually go to /etc/ as a kind of
system-wide configuration?
> - I think the fortify complaint about slave and stubslave is
> probably
> because they are so minimal. I don't think they use any libc
> functions actually.
OK, could be a wrong positive (didn't check)
> - There's no obvious override for the duplicate changelog warning.
The problem is that dh_installchangelogs will pick it up, but you've
got it also specified in d/docs.
You shouldn't install the doc INSTALL, as this is not relevant for
Debian binary packages -- it talks mostly about how to compile etc.
(README.Debian takes it job appearantly already)
> - Revisit d/changelog to make sure the package changes are fully
> captured.
Yes, they are super-verbose now... (even a bit too much, but how should
you know ;-) Example:
* As the package is being adopted by Stephen Dennis
<brazilofmux@gmail.com>,changed the Maintainer in debian/control
from Ervin Hearn III <noltar@korongil.net> to Stephen Dennis
<brazilofmux@gmail.com>.
While this explains the why very well (and is too extensive on the what
(this is will be in the diff) Convention is just to write:
* New maintainer. (Closes: #YourITABugNumber)
The others are also a bit extensive on the "what" area, but I suggest
that this is declared "OK" -- extensive is better than terse.
> - It would be nice to get make -j2 working. They did work once upon
> a
> time. Might be better to fix that upstream.
Yes, I do not consider this as a blocking point for now.
> - Test. The prettiest package in the world doesn't necessarily
> install
> anything that works.
Of course.
One thing I noted: NOTES mentions there is a default password. (I guess
it it a kind of admin password) This is a bad idea, securitywise and
should be changed.
> On Wed, Jan 4, 2017 at 4:32 PM, Tobias Frost <tobi@debian.org> wrote:
>
> > Am Donnerstag, den 05.01.2017, 00:24 +0100 schrieb Tobias Frost:
> > >
> > > I wrote you a rule file as starting point. Attached. It is
> > > thought to
> > > get you started.
> > > (Some parts are missing, like the hardening; also stuff and you
> > > need
> > > to
> > > do outside of the rules, like to create the file d/clean with all
> > > files
> > > listed and d/install to to put the files actually in place
> > >
> >
> > PS: I needed to add --no-parallel because parallel build is broken
> > here. This is also bug in your Makefile...
> >
> > To trigger
> > #debuild -j1
> > (works)
> >
> > #debuild -j4
> > (...)
> > g++ -g -O2 -fdebug-prefix-
> > map=/home/tobi/workspace/deb/mentors/Jan03/tinymux-2.10.1.13=.
> > -fstack-
> > protector-strong -Wformat -Werror=format-security -Wall -O3 -fomit-
> > frame-pointer -Wdate-time -D_FORTIFY_SOURCE=2 -g -O -
> > DSTUB_SLAVE -Wl,-z,relro -Wl,-z,now -o stubslave stubslave.o
> > -L.
> > -lm -lcrypt -lmux
> > /usr/bin/ld: cannot find -lmux
> > collect2: error: ld returned 1 exit status
> > Makefile:189: recipe for target 'stubslave' failed
> > make[1]: *** [stubslave] Error 1
> > make[1]: *** Waiting for unfinished jobs....
> > ( if [ -f netmux ]; then mv -f netmux netmux~ ; fi )
> > g++ -g -O2 -fdebug-prefix-
> > map=/home/tobi/workspace/deb/mentors/Jan03/tinymux-2.10.1.13=.
> > -fstack-
> > protector-strong -Wformat -Werror=format-security -Wall -O3 -fomit-
> > frame-pointer -Wdate-time -D_FORTIFY_SOURCE=2 -g -O -
> > DSTUB_SLAVE -Wl,-z,relro -Wl,-z,now -o netmux _build.o
> > alarm.o
> > alloc.o attrcache.o boolexp.o bsd.o command.o comsys.o conf.o
> > cque.o
> > create.o db.o db_rw.o eval.o file_c.o flags.o funceval.o
> > funceval2.o
> > functions.o funmath.o game.o help.o htab.o local.o log.o look.o
> > mail.o
> > match.o mathutil.o mguests.o modules.o move.o muxcli.o netcommon.o
> > object.o predicates.o player.o player_c.o plusemail.o powers.o
> > quota.o
> > rob.o pcre.o set.o sha1.o speech.o stringutil.o strtod.o svdrand.o
> > svdhash.o timer.o timeabsolute.o timedelta.o timeparser.o
> > timeutil.o
> > timezone.o unparse.o utf8tables.o vattr.o walkdb.o wild.o
> > wiz.o version.o -L. -lm -lcrypt -lmux
> > /usr/bin/ld: cannot find -lmux
> > collect2: error: ld returned 1 exit status
> > Makefile:198: recipe for target 'netmux' failed
> > make[1]: *** [netmux] Error 1
> > make[1]: Leaving directory
> > '/home/tobi/workspace/deb/mentors/Jan03/tinymux-2.10.1.13/src'
> >
(Sorry, have to run now; see you next iteration)
--
tobi
Reply to: