[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#849918: RFS: tinymux/2.10.1.13-1



Very much appreciate the feedback. Willing to learn, but overwhelmed by the Debian machinery.

Stupid question at the top: If I dput another package, does it update this one or do I need to delete the currently uploaded package from mentors first?


- d/changelog. A lot has changed. Here are pointers to 'brief' change logs for 2.7, 2.9, and 2.10:

http://www.tinymux.org/changes27.txt
http://www.tinymux.org/changes29.txt
http://www.tinymux.org/changes.txt

That's four years of why to retrace, and the actual check-in messages from the repository would be much longer. Does Debian really want all of that?

- d/patches

  - Not sure what a dep3 header is, yet. More to learn.
  - All but one of the patches is checked-in upstream already.
  - I don't know how to have config.guess be updated at build time? Did not know about that one. Is this part of automake? TinyMUX is more autoconf than it once was, but it still doesn't use automake or libtool.
  - Dependency-created-noise.patch. The way users normally build TinyMUX is untar the package, ./configure;make depend;make. The 'make depend' scans all the include files and builds ".depend" which is then re-consumed by Makefile. It must exist -- at least empty. The Debian build system would see either way as a source change, but it isn't a change to taken upstream. It always changes in different ways in every environment.

- d/copyright dep5...OK, more to study. The copyright is the same as previous 2.6 package except for the dates. That was hammered out between the four MUSH flavors (PennMUSH, TInyMUSH, TinyMUX, and RhostMUSH). I'm loath to change the substance of it, but if there is some Debian-friendly form to call out that it is the Artistic license, that seems reasonable enough.

- silent rule. TinyMUX uses the other autoconf tools, but not libool or automake. Silent rule seems to be a term from those things?

- d/rules. I'm picking this up from the previous maintainer, Noltar, and there should be simpler ways of doing this now. I'm just not up to speed on them and haven't found examples I grok, yet. I want to use the simple debhelper method. dh, done.

Stephen

On Mon, Jan 2, 2017 at 11:41 PM, Tobias Frost <tobi@debian.org> wrote:
control: tags -1 moreinfo

Hallo Stephen,

(not taking ownership of the bug as I cannot guarantee to find time for
follow ups. Other DDs are welcome to take this bug)

Many thanks for your intention to adopt your pacakge.
I see that you're also upstream of it; this means that I can also
request to fix some upstream parts, like the build system ;-)

here is a review:

- d/changelog is incomplete. You've changed quite a bit in the debian
packaging, more than "new upstream reelase" ;-)
Please make sure that you really document everything you changed,
(and as this is often done wrong, the changelog should ensure that 
it explains the "why (have it been changed)" adequately.

- d/patches
  - they could have use of a dep3 header
  - as you're upstream, do you plan to roll out a new release with    
    them? (question out of curiosity, not required for sponsoring)

   autoconf patch:
  - you should not patch config.guess. They need to be updated on 
    build-time! (autotools-dev is your friend, and debhelper with 
    compat level 10 will be even better.)
   dependency-created-noise patch:
   - I'm not sure about this patch. What is its purpose?
     The header reads as it is for canceling changes due to the build
     process? Looks like it is regenerated at build time? If so, it
     should not be patched but mereley deleted in the clean target.
     (Otherwise the build system should be fixed that this is not 
      needed; automake is capable to create dependencie)

- d/copyright should be transferred to dep5 format.

- Please disable silent rules (the buildlog should emit all compiler
flags)

- d/rules should be converted to short debhelper format.
  - the buildsystem should be really fixed to properly clean up.
  - otherwise, errors from rm should not be ignored, also not errors
from make realclen. Just don't execute it when there is no Makefile.

(Stopping here for time reasons; especially I did not do a d/copyright
audit, not checked the upstream code)

Please fix above, remove the moreinfo tag, and -- time permitting -- I
will iterate.

--
tobi



Reply to: