Hello Alberto,
On Thu, Dec 29, 2016 at 05:01:29PM +0100, Alberto Luaces wrote:
> Sean Whitton writes:
> >
> > If not, you should merge the changelog entries for -1 and -2. It's just
> > confusing to have changlog entries that never made it into the Debian
> > archive.
> >
>
> Well, it seemed cleaner than modifying an already published history, but
> I understand no solution is immune to drawbacks. I have now pushed the
> new, fixed branch. Please note that you will have to re-synchronise, or
> clone the repository again from scratch.
Oh dear, that wasn't what I meant! I was suggesting you just make a
commit merging the changelog entries together. Anyway, it's done now.
I'd like to suggest some improvements to your changelog:
> * Updated d/control according to d.e.a.p.t. guidelines.
Only an existing team member would know what d.e.a.p.t. is! Perhaps add
the URI <http://pkg-emacsen.alioth.debian.org/elpa-hello/>?
You also rewrote d/rules, but this is not mentioned in the changelog.
> * Update standards to 3.9.8.
Did you have to change anything in the packaging for this update? If
not, it's conventional to write "(no changes required)".
> * Disabled parents in clojure mode due to upgrading errors.
This is meaningless to someone not already familiar with yasnippet. You
wrote a great patch header, so I would suggest just this changelog
entry:
* Add 0001-Avoid-.dpkg-new-upgrading-error.patch
Please accept my apologies for not raising these suggestions in a
previous e-mail, and thank you for your patience with this sponsorship
process -- I'm confident I'll be able to upload after your next update.
(don't forget dch -r)
--
Sean Whitton
Attachment:
signature.asc
Description: PGP signature