[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#849489: RFS: darksnow/0.7.1-1 [QA]



control: owner -1 !

Hello David,

On Wed, Dec 28, 2016 at 09:12:49PM +0000, David Davies-Jones wrote:
> I've tried addressing the issues you've raised and re-uploaded to mentors. If
> there are any more problems please let me know

Thanks for your updated package.  I'm sorry not to have raised this in
my previous message, but there are other changes you've made that are
not documented in the changelog.  For example, you dropped some
build-dependencies, and you renamed a quilt patch.  Please check the
difference between 0.6.1-3 and 0.7.1-1 carefully.

Tip: it's easier if you work in git, rather than just handling source
packages.  This is what I just did to review your work:

    % dget -d https://mentors.debian.net/debian/pool/main/d/darksnow/darksnow_0.7.1-1.dsc
    % dgit clone darksnow
    % dgit import-dsc ../darksnow_0.7.1-1.dsc david
    % git checkout david
    % git diff dgit/dgit/sid..HEAD

By the way, it would be good to forward your darksnow.desktop upstream
(that won't be reflected in your QA upload, of course).

--
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: