[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#849489: RFS: darksnow/0.7.1-1 [QA]



Hello

I've tried addressing the issues you've raised and re-uploaded to mentors. If there are any more problems please let me know

Many thanks

David Jones

On 27 December 2016 at 22:07, Sean Whitton <spwhitton@spwhitton.name> wrote:
control: tag -1 +moreinfo

Dear David,

Thanks for your source package.  A few comments:

On Tue, Dec 27, 2016 at 08:04:33PM +0000, David Davies-Jones wrote:
>  * QA upload.
>  * New upstream release (Closes: #839027)
>  * Set maintainer to QA Group

It would be good to refer to the orphaning bug here.  E.g. "(see
#xxxxxx)".

>
>  * Converted rules to dh format
>  * Compat level 10
>  * Converted patches to quilt & refreshed

Did you change the source package format?  Please say this explicitly.

>
>  * Converted copyright to DEP-5
>  * Standards version 3.9.8

Did you have to update anything in the packaging to conform to this new
standards version?  If not, it's conventional to append "(no changes
required)".

>  * Replaced menu file with desktop

I think you mean "with a desktop file" -- and do you mean the menu file
in the debian/ directory?  Please be more explicit.

Changes missing from changelog:

- added d/clean
- stopped installing darksnow_icon.xpm

--
Sean Whitton


Reply to: