Hi Michael, On 2016-12-18 16:55+0100, Michael Stapelberg wrote: > Thanks for working on this package! Thanks for you review! > If you’re willing to move this package to pkg-go, I’m willing to sponsor > it :). Please see https://pkg-go.alioth.debian.org/ I'll be happy to do that. Is using dh-golang a prerequisite for moving the package to pkg-go? > Félix Sipma <felix+debian@gueux.org> writes: >> Download with dget: >> >> dget -x https://mentors.debian.net/debian/pool/main/r/restic/restic_0.3.1-1.dsc > > First review round comments: > > • Why do you install the source code to /usr/lib/go/src? Is restic > intended to be used as a library? If yes, can you split the source > into a -dev package? That was intended as a workaround to a hybrid dh-golang/"go build.go" build process error. I just fixed this. > • Upstream commented that it should be possible to use the go tool for > building instead of build.go: > https://github.com/restic/restic/issues/355#issuecomment-267026832 > Could you please switch to using the go tool with dh-golang and drop > the patch for build.go? Using dh-golang was my first try, and it failed (I don't remember how bad it failed, though). I can try again if needed. > • Can you please place debian/* under the same license as the upstream > code itself to prevent issues with patching? If possible, I'll prefer to keep GPL-3+ for my contributions. I understand the rationale, but the patches currently in debian/patches are not intended for being forwarded upstream, and if another patch is added, the copyright can still be adjusted to match upstream in debian/copyright. > • Can you please enable gbp’s pristine-tar feature in gbp.conf? done > • Can you please move the git repository to the pkg-go directory on > alioth? I'll do that if you confirm that dh-golang is not required in pkg-go. I'll try to address the other concerns concerning the package on the github issue https://github.com/restic/restic/issues/355 and then I'll upload a new version of the package to mentors.
Attachment:
signature.asc
Description: PGP signature