[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#848148: RFS: restic/0.3.1-1



Hi Félix,

Thanks for working on this package!

If you’re willing to move this package to pkg-go, I’m willing to sponsor
it :). Please see https://pkg-go.alioth.debian.org/

Félix Sipma <felix+debian@gueux.org> writes:
> Download with dget:
>
>     dget -x https://mentors.debian.net/debian/pool/main/r/restic/restic_0.3.1-1.dsc

First review round comments:

• Why do you install the source code to /usr/lib/go/src? Is restic
  intended to be used as a library? If yes, can you split the source
  into a -dev package?

• Upstream commented that it should be possible to use the go tool for
  building instead of build.go:
  https://github.com/restic/restic/issues/355#issuecomment-267026832
  Could you please switch to using the go tool with dh-golang and drop
  the patch for build.go?

• Can you please place debian/* under the same license as the upstream
  code itself to prevent issues with patching?

• Can you please enable gbp’s pristine-tar feature in gbp.conf?

• Can you please move the git repository to the pkg-go directory on
  alioth?

-- 
Best regards,
Michael


Reply to: