On Tue, Nov 08, 2016 at 06:22:34PM +0100, Julien Puydt wrote:
> > * d/copyright looks outdated; at least your own copyright is, but please
> > look over all of it.
> > + maybe stop mixing tabs and spaces so irregularly too?
>
> I tried to rework it.
well, it surely has a better look now ;)
> > * d/rules:
> > + could you instead inject the -D_LARGEFILE_SOURCE by using
> > dpkg-buildflags' means? (i.e. DEB_CPPFLAGS_MAINT_APPEND variable)
> > autotools should be able to deal with it correctly even without
> > passing it at configure time like that.
>
> Well... now you mention it :
> (1) it wasn't autotools-based when I made the package, so that might explain
> why everything was passed to the "configure" script ;
> (2) it's one of the first packages I made, so I might have had no real clue
> what I was doing ;
> (3) pbuilder says it compiles as well without it!
>
> ==> Conclusion: axed!
_LARGEFILE_SOURCE is one of those definition that enables LFS support;
one way to check whether you killed LFS support by it too is to build on
i386 and run lintian with info tags enabled; there is this tag:
https://lintian.debian.org/tags/binary-file-built-without-LFS-support.html
anyway, --enable-shared --disable-static should be free to go too while
you're on it (I'm not sure off-hand about --disable-static, tbh)
> > + can't that thing be moved over to dh_auto_install instead of
> > manually calling make?
>
> Well, since the move to autotools, I don't think that is necessary : axed!
> And pbuilder is still happy.
by that you also removed the thing that was deleting the *.la, btw.
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature