control: owner -1 ! control: tag -1 moreinfo On Tue, Nov 08, 2016 at 05:40:45PM +0100, Julien Puydt wrote: > I am looking for a sponsor for my package "eclib" o/ > Vcs-Git: > https://anonscm.debian.org/git/debian-science/packages/eclib.git * please kill the dh-autoreconf build-dep * d/copyright looks outdated; at least your own copyright is, but please look over all of it. + maybe stop mixing tabs and spaces so irregularly too? * d/rules: + could you instead inject the -D_LARGEFILE_SOURCE by using dpkg-buildflags' means? (i.e. DEB_CPPFLAGS_MAINT_APPEND variable) autotools should be able to deal with it correctly even without passing it at configure time like that. + can't that thing be moved over to dh_auto_install instead of manually calling make? > - I cleaned d/rules with a rusty axe. :) -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature