[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#832704: RFS: nixnote2/2.0~beta8+20160727+ds-1 [ITP] -- Open Source Evernote client



Hello,

On Sun, Sep 04, 2016 at 09:41:06AM +0800, Paul Wise wrote:
> > From the links you've provided, it seems that the Evernote *.thrift
> > files ought to be packaged as a build-dependency which are then used to
> > generate the *.cpp files when the package is build.
> >
> > If it's impossible to regenerate them, arguably we wouldn't be shipping
> > the full source code to qevercloud.  Opinions in Debian diverge here,
> > though.  You might consider asking on debian-devel@lists.debian.org for
> > anyone else who has dealt with files generated from *.thrift files in
> > their packaging work.
> 
> The DFSG and ftp-master policy is fairly clear on this:
> 
> https://ftp-master.debian.org/REJECT-FAQ.html
> https://www.debian.org/social_contract#guidelines

I should be clear that what I had in mind was the question of *actually
regenerating* the files during the build process, not just the question
of including them in the source package with a promise that the
regeneration will actually work -- which is of course required.  There
are diverging opinions about running autoconf during the package build
or not.

> >> Issue sent (https://github.com/baumgarr/nixnote2/issues/201).
> >
> > As well as removing the theme files from the tarball using
> > "Files-Excluded:", you seem to have edited theme.ini.  It would be
> > better not to edit theme.ini in the tarball and instead use a quilt
> > patch, since it's a Debian-specific change.  The reason for this is that
> > it allows you to explain what's going on in a patch header, so others
> > can see why the purple theme was removed.
> 
> FYI, just because the images mention Inkscape, GIMP or other tools in
> their meta-data does not mean that there is non-PNG source for the
> images. Upstream could have prepared the image in that tool, not saved
> the SVG/XCF files, exported the PNG file and closed the program. There
> is no reason to remove the purple theme unless you have clear proof
> that upstream is withholding the source files.
> 
> That is completely separate to the license concern mentioned in the
> issue that you filed of course.

Right: the unclear authorship/license is the main problem right now.

-- 
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: