Bug#832704: RFS: nixnote2/2.0~beta8+20160727+ds-1 [ITP] -- Open Source Evernote client
On Sun, Sep 4, 2016 at 1:53 AM, Sean Whitton wrote:
>> > ... generated cpp source files in qevercloud ...
>>
>> That is generated from Evernote Cloud API Thrift IDL files [1], an abstract
>> description of Evernote Cloud API, and generated files should be considered
>> as part of the source code. It is barely impossible and does not make sense
>> to regenerate those files.
>>
>> [1] https://github.com/evernote/evernote-thrift , some more stories in
>> https://blog.evernote.com/tech/2011/05/26/evernote-and-thrift/ .
>
> From the links you've provided, it seems that the Evernote *.thrift
> files ought to be packaged as a build-dependency which are then used to
> generate the *.cpp files when the package is build.
>
> If it's impossible to regenerate them, arguably we wouldn't be shipping
> the full source code to qevercloud. Opinions in Debian diverge here,
> though. You might consider asking on debian-devel@lists.debian.org for
> anyone else who has dealt with files generated from *.thrift files in
> their packaging work.
The DFSG and ftp-master policy is fairly clear on this:
https://ftp-master.debian.org/REJECT-FAQ.html
https://www.debian.org/social_contract#guidelines
>> > There's a further issue with at least some of the files in images/.
>> > The check-all-the-things tool reveals:
>> >
>> > # Check with upstream where the GIMP XCF source files are.
>> > $ find -type f \( -iname '*.png' -o -iname '*.gif' -o -iname '*.jpg' -o -iname '*.jpeg' \) -exec grep -iF gimp {} +
>> > Binary file ./images/purple-theme/synchronize.png matches
>> >
>> > i.e. images/purple-theme/synchronize.png was probably created with the
>> > GIMP. That means the preferred format for modifying this file is
>> > probably a *.svg file. Similarly, the other files in the theme might
>> > have been prepared with a tool that works with *.svg files and exports
>> > to *.png.
>> >
>> > In order to satisfy DFSG (and indeed the GPL), the *.svg files need to
>> > be included in the source package.
>>
>> Upstream gives no response, and I am patching to move the entire purple
>> theme away from the source code for now.
>>
>> Issue sent (https://github.com/baumgarr/nixnote2/issues/201).
>
> As well as removing the theme files from the tarball using
> "Files-Excluded:", you seem to have edited theme.ini. It would be
> better not to edit theme.ini in the tarball and instead use a quilt
> patch, since it's a Debian-specific change. The reason for this is that
> it allows you to explain what's going on in a patch header, so others
> can see why the purple theme was removed.
FYI, just because the images mention Inkscape, GIMP or other tools in
their meta-data does not mean that there is non-PNG source for the
images. Upstream could have prepared the image in that tool, not saved
the SVG/XCF files, exported the PNG file and closed the program. There
is no reason to remove the purple theme unless you have clear proof
that upstream is withholding the source files.
That is completely separate to the license concern mentioned in the
issue that you filed of course.
--
bye,
pabs
https://wiki.debian.org/PaulWise
Reply to: