[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#833187: RFS: yuma123/2.8-1 [ITP] -- netconf/YANG toolchain



Vincent,

I have uploaded the new yuma123_2.8+dfsg-1 package with the corrections - https://mentors.debian.net/package/yuma123

On 08/06/2016 10:10 PM, Vincent Bernat wrote:
control: owner -1 !

  ❦  2 août 2016 00:25 CEST, Vladimir Vassilev <vladimir@transpacket.com> :

libyuma-base - Netconf configuration script, YANG models and documentation
libyuma-dev - Netconf/YANG development files
libyuma2   - Netconf/YANG library
libyuma2-dbg - Netconf/YANG library debug
netconfd   - netconf (RFC-6241) agent
netconfd-module-ietf-interfaces - SIL module for netconfd implementing ietf-interfaces.yang
netconfd-module-ietf-system - SIL module for netconfd implementing ietf-system.yang
yangcli    - netconf/YANG command line client application
  - d/watch: missing, please add one. It allows you (or me) to
    conveniently know if there is a new version available. This appears
    on various tools like tracker.debian.org or qa.debian.org.
[1] fixed

  - d/control: no need to Build-Depends on autotools-dev, dh-autoreconf
    already does everything.
[2] ! did try to remove autotools-dev but lintian was reporting error without it. With updated pbuild environment.

  - d/control: the latest Standards-Version is 3.9.8.
[3] fixed

  - d/control: the Homepage should be the homepage of the software, not
    the homepage of the company backing it.
[4] fixed (changed to https://sourceforge.net/projects/yuma123)

  - d/control: there is an extra dot at the end of the long description
    of libyuma-base
[5] fixed

  - d/control: drop the libyuma2-dbg package, they are now generated
    automatically.
[6] fixed

  - d/control: no need to depends on libc6-dev for libyuma-dev, this
    package is part of build-essentials.
[7] fixed

  - d/control: you can drop the versioned dependency on lsb-base as the
    requested version is available even in oldstable (and the package it
    self is priority required)
[8] fixed

  - d/control: libyuma2 dependency should come directly from
    ${shlibs:Depends}, isn't it?
[9] fixed

  - d/copyright: the file uses almost DEP-5 format except the header is
    missing and the licenses are not formatted correctly (missing space
    column and dot between paragraphs). See:
    http://dep.debian.net/deps/dep5/#header-paragraph
[10] fixed

  - d/copyright: add a section for debian/* using the most prominent
    license and with yourself as copyright holder.
[11] fixed

  - d/copyright: there are some missing files and copyright holders, like
    "Netconf Central", "Bob Trower/Trantor Standard Systems"... rgrep -i
    copyright to find them
[12] fixed

  - d/patches: I don't think that the patch is useful. If it's just here
    to not have a debian directory elsewhere in the tree, it's not
    needed.
[13] !(removed the part deleting example-modules/*/debian (indeed unnecessary noise) however the important part of the patch is rewiring the example-modules/*/Makefile.am configure.ac and Makefile.am to build the standalone examples as integrated packages part of the yuma123 source package)

  - d/rules: only use autoreconf, let dh_strip generate dbgsym package
    itself
[14] fixed

  - add a lintian override for (with a comment explaining the three
    libraries share the same source and API/ABI versioning and don't need
    3 different packages):
      libyuma2: package-name-doesnt-match-sonames libyumaagt2 libyumamgr2 libyumancx2
[15] fixed

  - you may want to add a libyuma2.symbols file. It can be generated with
    dpkg-gensymbols (and modified manually to remove the debian part of
    the version number).
[16] !(generated the file 2067 lines, 63576 bytes. The "may" you use and the size of the file tilted the scales on deciding not to add a libyuma2.symbols file if you do not have it as a mandatory requirement)

How should netconfd be running? I see that netconf-subsystem should be
configured inside OpenSSH. What about netconfd? Is it spawned by
netconf-subsystem?

Some files are generated. They are marked with "Generated by
yangdump". This means you'll have to build them during build. If this is
already possible in the default build system, just ensure they are
removed before build by adding them to debian/clean.

The MIB files are not free material and you need to strip them from the
original tarball. To do that, the easiest way is to add them to
debian/copyright. This is explained in the manual page of uscan (you
need the debian/watch file to work correctly). You'll need to add +dfsg
extension to the version: 2.8+dfsg for the upstream version, 2.8+dfsg-1
for the Debian version. If some of the files above are generated from
the MIB, this is quite annoying as I don't have a solution for this.

I see that the .yang files are copyright IETF/Internet Society. I have
looked to a few of them and they use a "simplified BSD license". I don't
know if this is the 1-clause or 2-clause one. You should add the
appropriate section in debian/copyright.
[17] fixed (3-clause same as the rest)
.Some other files are generated
 From the MIB. You cannot use them, sorry. There may be some debate here
as MIB are used as an interface documentation. However, they are really
non-free material. Maybe bringing this to debian-legal@ may help.
[18] resolved by removing all MIBs and products generated from MIBs from 2.8+dfsg

Except the RFC stuff, most problems are rather small and the package
looks good!

On 08/07/2016 05:02 PM, Vincent Bernat wrote:
  ❦  7 août 2016 16:40 CEST, Vladimir Vassilev <vladimir@transpacket.com> :

That is correct they are only initial templates that have been
generated by yangdump (mib2c equivalent tool) a long time ago and
maintained manually afterwards. Only
./netconf/src/agt/agt_yuma_arp.{c,h}
./netconf/src/agt/agt_time_filter.{c,h}. No problem there.
You may want to add a specific comment in debian/copyright for
that. Something like that:

Files: ...
Copyright: ...
License: ...
Comment:
   The skeleton of those files were generated by the yangdump tool which
   generates the boilerplate to build new modules. They are now maintained
   manually and constitute the preferred form of modification.
IMO there is no problem here since the particular YANG models
(yuma-arp.yang yuma-time-filter.yang) used to generate the initial
templates are part of the Yuma project and licensed under the same BSD
copyright as the rest of the project code. This is not the case where
one of the removed IETF MIBs was used to generate the template. Do you
agree with that?
It is not a copyright problem, it is a problem that the DFSG mandates
the build of everything from the preferred form of modification. Without
the comment, the package could be rejected on the ground that those
files are marked as generated. A note in the debian/copyright will save
you the time to explain it is not the case.
[19] fixed

As for the ones that were generated from IETF MIB, if they are in the
same case, it is believed that API cannot be copyrighted. They could
therefore be licensed with the BSD license as well. Only the MIB
themselves must be removed. But this could be more debatable. Your pick.
Vladimir


Reply to: