[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#833187: RFS: yuma123/2.8-1 [ITP] -- netconf/YANG toolchain



control: owner -1 !

 ❦  2 août 2016 00:25 CEST, Vladimir Vassilev <vladimir@transpacket.com> :

> libyuma-base - Netconf configuration script, YANG models and documentation
> libyuma-dev - Netconf/YANG development files
> libyuma2   - Netconf/YANG library
> libyuma2-dbg - Netconf/YANG library debug
> netconfd   - netconf (RFC-6241) agent
> netconfd-module-ietf-interfaces - SIL module for netconfd implementing ietf-interfaces.yang
> netconfd-module-ietf-system - SIL module for netconfd implementing ietf-system.yang
> yangcli    - netconf/YANG command line client application

 - d/watch: missing, please add one. It allows you (or me) to
   conveniently know if there is a new version available. This appears
   on various tools like tracker.debian.org or qa.debian.org.

 - d/control: no need to Build-Depends on autotools-dev, dh-autoreconf
   already does everything.

 - d/control: the latest Standards-Version is 3.9.8.

 - d/control: the Homepage should be the homepage of the software, not
   the homepage of the company backing it.

 - d/control: there is an extra dot at the end of the long description
   of libyuma-base

 - d/control: drop the libyuma2-dbg package, they are now generated
   automatically.

 - d/control: no need to depends on libc6-dev for libyuma-dev, this
   package is part of build-essentials.

 - d/control: you can drop the versioned dependency on lsb-base as the
   requested version is available even in oldstable (and the package it
   self is priority required)

 - d/control: libyuma2 dependency should come directly from
   ${shlibs:Depends}, isn't it?

 - d/copyright: the file uses almost DEP-5 format except the header is
   missing and the licenses are not formatted correctly (missing space
   column and dot between paragraphs). See:
   http://dep.debian.net/deps/dep5/#header-paragraph

 - d/copyright: add a section for debian/* using the most prominent
   license and with yourself as copyright holder.

 - d/copyright: there are some missing files and copyright holders, like
   "Netconf Central", "Bob Trower/Trantor Standard Systems"... rgrep -i
   copyright to find them.

 - d/patches: I don't think that the patch is useful. If it's just here
   to not have a debian directory elsewhere in the tree, it's not
   needed.

 - d/rules: only use autoreconf, let dh_strip generate dbgsym package
   itself

 - add a lintian override for (with a comment explaining the three
   libraries share the same source and API/ABI versioning and don't need
   3 different packages):
     libyuma2: package-name-doesnt-match-sonames libyumaagt2 libyumamgr2 libyumancx2

 - you may want to add a libyuma2.symbols file. It can be generated with
   dpkg-gensymbols (and modified manually to remove the debian part of
   the version number).

How should netconfd be running? I see that netconf-subsystem should be
configured inside OpenSSH. What about netconfd? Is it spawned by
netconf-subsystem?

Some files are generated. They are marked with "Generated by
yangdump". This means you'll have to build them during build. If this is
already possible in the default build system, just ensure they are
removed before build by adding them to debian/clean.

The MIB files are not free material and you need to strip them from the
original tarball. To do that, the easiest way is to add them to
debian/copyright. This is explained in the manual page of uscan (you
need the debian/watch file to work correctly). You'll need to add +dfsg
extension to the version: 2.8+dfsg for the upstream version, 2.8+dfsg-1
for the Debian version. If some of the files above are generated from
the MIB, this is quite annoying as I don't have a solution for this.

I see that the .yang files are copyright IETF/Internet Society. I have
looked to a few of them and they use a "simplified BSD license". I don't
know if this is the 1-clause or 2-clause one. You should add the
appropriate section in debian/copyright. Some other files are generated
From the MIB. You cannot use them, sorry. There may be some debate here
as MIB are used as an interface documentation. However, they are really
non-free material. Maybe bringing this to debian-legal@ may help.

Except the RFC stuff, most problems are rather small and the package
looks good!
-- 
Debian package sponsoring guidelines:
 https://vincent.bernat.im/en/debian-package-sponsoring.html

Attachment: signature.asc
Description: PGP signature


Reply to: