[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#833187: RFS: yuma123/2.8-1 [ITP] -- netconf/YANG toolchain





On 08/07/2016 04:29 PM, Vincent Bernat wrote:
  ❦  7 août 2016 15:50 CEST, Vladimir Vassilev <vladimir@transpacket.com> :

Some files are generated. They are marked with "Generated by
yangdump". This means you'll have to build them during build. If this is
already possible in the default build system, just ensure they are
removed before build by adding them to debian/clean.
Note that NetSNMP has also a lot of files that are generated from MIB
(with mib2c). I don't know if they are specifically marked as is but
the generated form is just a template. Maybe it's also the case with yuma?
That is correct they are only initial templates that have been
generated by yangdump (mib2c equivalent tool) a long time ago and
maintained manually afterwards. Only
./netconf/src/agt/agt_yuma_arp.{c,h}
./netconf/src/agt/agt_time_filter.{c,h}. No problem there.
You may want to add a specific comment in debian/copyright for
that. Something like that:

Files: ...
Copyright: ...
License: ...
Comment:
  The skeleton of those files were generated by the yangdump tool which
  generates the boilerplate to build new modules. They are now maintained
  manually and constitute the preferred form of modification.
IMO there is no problem here since the particular YANG models (yuma-arp.yang yuma-time-filter.yang) used to generate the initial templates are part of the Yuma project and licensed under the same BSD copyright as the rest of the project code. This is not the case where one of the removed IETF MIBs was used to generate the template. Do you agree with that?


Reply to: