Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP
> I thought you were finished after evil and its dependencies :) Glad to
> see more ELPA packages. Here's a review for you.
Thank you. There are still dependencies of my .emacs that are not in
Debian.
> 1. The "-el" suffix on the source package name is pointless because the
> name already contains "elisp" so it's clear that it's an Emacs
> package. Please consider dropping the suffix. On the Emacsen team
> we use upstream names where possible.
Done.
> 2. Have you forwarded 0001-Fix-Package-Version-header.patch upstream?
Upstream not interested. Melpa generates version from git tag.
> 3. Please patch README.md to remove the installation instructions (might
> be confusing to someone who has already installed the package) and
> remove the MELPA badges from the top (useless in plain text).
Done.
> 4. No pristine-tar branch is available. For the sake of the sponsorship
> process it might be worth adding one.
Should be there, but binary files in git make me uneasy.
--
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Web-Site: sinsekvu.github.io
Reply to: