Bug#828889: RFS: elisp-slime-nav-el/0.9-1 ITP

[Sean Whitton <spwhitton@spwhitton.name>]

control: owner -1 !
control: tag -1 +moreinfo

Hello Dmitry,

I thought you were finished after evil and its dependencies :)  Glad to
see more ELPA packages.  Here's a review for you.

1. The "-el" suffix on the source package name is pointless because the
   name already contains "elisp" so it's clear that it's an Emacs
   package.  Please consider dropping the suffix.  On the Emacsen team
   we use upstream names where possible.

2. Have you forwarded 0001-Fix-Package-Version-header.patch upstream?

3. Please patch README.md to remove the installation instructions (might
   be confusing to someone who has already installed the package) and
   remove the MELPA badges from the top (useless in plain text).

4. No pristine-tar branch is available.  For the sake of the sponsorship
   process it might be worth adding one.

I installed the package and it seems to work well!

On Tue, Jun 28, 2016 at 10:50:00PM -0400, Sergio Durigan Junior wrote:
> 1) The links listed on the Vcs-* fields are not valid, so perhaps you
> may want to (a) push your git repo temporarily at another URL, or (b)
> create the repo under collab-maint/ and push your things there.

They seem to work now!

> 3) Any reason why you're using debhelper version 10?  It's still
> experimental, so you probably should be using version 9.

My guess is that he generated the packaging with dh-make-elpa.  It sets
compat 10 in order to enable dh_elpa_test.  In this case, it's not
necessary since there is no test suite.

-- 
Sean Whitton