Bug#827913: RFS: goto-chg/1.6-1 ITP
> 1. The long description is not grammatical English. I appreciate you're
> not a native speaker, so I fixed it for you in the team git
> repository.
Thanks.
> 2. I noticed with all of your packages that I reviewed that there is no
> trailing newline at the end of your files. My Emacs keeps trying to
> add it... is there some reason for this? Obviously not a blocker for
> sponsorship.
Bad habit. Sorry.
> 3. Any particular reason you are using gz and not xz compression in
> gbp.conf? Also, it might be a good idea to check the tarball into
> git with pristine-tar so that a sponsor has exactly the same one (I
> generated my own for testing).
None. Just cut-and-yank from paredit package.
> 4. Please add a d/watch file.
Need help with it. No idea how to track versions on Emacs wiki.
> 5. You could extract the upstream changelog from goto-chg.el and install
> it.
Done.
> 6. I don't think the copy of the code on the Emacs Wiki counts as a
> "Homepage". It's the correct thing to put in Source: field of
> d/copyright, but I don't think it should go in d/control.
Done.
We probably need to make emacsen policy more... verbose.
--
Accept: text/plain, text/x-diff
Accept-Language: eo,en,ru
X-Web-Site: sinsekvu.github.io
Reply to: