[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#827913: RFS: goto-chg/1.6-1 ITP



control: owner -1 !
control: tag -1 +moreinfo

Hello Dmitri,

Thanks for this!  Here's a review.

1. The long description is not grammatical English.  I appreciate you're
   not a native speaker, so I fixed it for you in the team git
   repository.

2. I noticed with all of your packages that I reviewed that there is no
   trailing newline at the end of your files.  My Emacs keeps trying to
   add it... is there some reason for this?  Obviously not a blocker for
   sponsorship.

3. Any particular reason you are using gz and not xz compression in
   gbp.conf?  Also, it might be a good idea to check the tarball into
   git with pristine-tar so that a sponsor has exactly the same one (I
   generated my own for testing).

4. Please add a d/watch file.

5. You could extract the upstream changelog from goto-chg.el and install
   it.

6. I don't think the copy of the code on the Emacs Wiki counts as a
   "Homepage".  It's the correct thing to put in Source: field of
   d/copyright, but I don't think it should go in d/control.

--
Sean Whitton

Attachment: signature.asc
Description: PGP signature


Reply to: