control: tag -1 +moreinfo Hello again JCF, Here's a more complete review. I hope it is helpful to you. I ran debdiff and found that the new version installs /usr/share/xpad/help/xpad-user-help.txt. Shouldn't this be in /usr/share/doc/xpad? If xpad needs to load this file, you could make a symlink from /usr/share/xpad/help to /usr/share/doc or add a patch. You seem to have added an upstream signing key and modified d/watch, but I couldn't find mention of this in your changelog entry. On Sat, Jun 11, 2016 at 03:03:38PM +0200, JCF Ploemen wrote: > * New upstream release: (Closes: #805723) (LP: #1525656) > + fixes markup issue in russian translation. (Closes: #797630) > + fixes moving xpad window rendering the application unresponsive. > (Closes: #614337) > + includes a configurable wait for the systray. (Closes: #555934) It's great you are closing so many bugs :) > * Patches: > + remove missing.diff, no longer needed. It would be good to say in the changelog why it's no longer needed (obsoleted by XX? applied upstream?). > * Remove Debian menu support as per #741573. That is a very long bug report. It would be better to refer to the section of the Debian Policy that states the deprecation. > * Control: > + add build-depends on libgtk-3-dev, libgtksourceview-3.0-dev, > dh-autoreconf. > + remove build-depends on libgtk2.0-dev, libmagickcore-extra, > autotools-dev, imagemagick. > + add VCS links. > + change upstream homepage to their launchpad site. > * Bump compat and debhelper version to 9. I think you mean "debhelper build dependency". Bumping the version of debhelper means making a release of debhelper... It seems that you ran wrap-and-sort to improve the formatting of the control file. This is usually mentioned in the Debian changelog with the options that you passed to wrap-and-sort, e.g. * Run wrap-and-sort -abst > * Docs: don't install AUTHORS, THANKS, TODO (not relevant for end > users) or NEWS (superseded by ChangeLog). (It's been discussed above that I think this is unnecessary and has the potential to damage relations with upstream; just mentioning it here so that this e-mail forms a complete review.) > * Rules: > + simplify to just dh sequencer with autoreconf. > + enable all hardening. Are you sure you need the override_dh_installchangelogs target? I thought that dh_installchangelogs automatically tried common names like "ChangeLog". > * Copyright: > + convert to machine-readable format. > + update all upstream info. > + add myself as a copyright holder for the packaging. > * Bump Standards-Version to 3.9.8 (from 3.9.3; no further changes). > > > Regards. -- Sean Whitton
Attachment:
signature.asc
Description: PGP signature