Bug#823187: RFS: icdiff/1.7.3-1

[Sascha Steinbiss <satta@tetrinetsucht.de>]

Hi Paul,

thanks for your quick reply.

[...]
> Interesting. Personally if I were upstream I'd drop the curl method and
> go with pip but I understand it is a simple and thus useful hack.

So would I, but I respect upstream's wishes and there was also a user
who preferred the simple, stand-alone script solution.

> How about this?
> 
> Rename icdiff to icdiff.py and make it a module.
> 
> Put a bin/icdiff in the repo that just imports and runs the icdiff
> module. It can't be icdiff since people who run the same install
> instructions should get a file not found error instead of confusing
> import failure when trying to run the script.

That would be an option indeed, except that I think it will not work if
one just clones the github repo without installing (as the module is not
in a searched path yet).

> Add some code to icdiff.py so it can be run on the cmdline too.

AFAICS this would be possible when merging
https://github.com/jeffkaufman/icdiff/pull/75 -- which I would advise.

> Update the web page curl install info to point at icdiff.py

Upstream explicitly says he wants to have icdiff without a .py suffix.
Of course it's trivial to have curl write it into a suffixless file, but
if you do that you can't use the downloaded file as a module.

> Have setup.py install bin/icdiff as a script and icdiff.py as a module.

This is pretty much how it's done in PR #75, except bin/icdiff is
created by setuptools via the entrypoint approach and not included in
the original repo.

I will think about it a bit more and discuss these options with
upstream. Maybe he also just makes a call in favour or against the
module functionality, or someone comes up with a new solution.

>> New upload is here: https://mentors.debian.net/debian/pool/main/i/icdiff/icdiff_1.8.1-1.dsc
> 
> I'll take a look on the weekend.

Great, thanks!


-- 
 The Wellcome Trust Sanger Institute is operated by Genome Research 
 Limited, a charity registered in England with number 1021457 and a 
 company registered in England with number 2742969, whose registered 
 office is 215 Euston Road, London, NW1 2BE.