[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#823187: RFS: icdiff/1.7.3-1



On Thu, 2016-05-12 at 22:37 +0100, Sascha Steinbiss wrote:

> Upstream is still unsure how to address this problem properly given
> that he wants to retain a specific structure to his code. There have
> been a few suggestions and PRs from myself and others, but they are
> apparently not quite what upstream is going for. For more information
> see https://github.com/jeffkaufman/icdiff/issues/68 and
> https://github.com/jeffkaufman/icdiff/pull/79. ;
> For simplicity’s sake in the meantime, I have skipped using
> setuptools in the Debian package and just install the single stand-
> alone script manually, an option that upstream explicitly wants to
> support anyway. I hope that is acceptable for a first upload as it
> does’t change much in the installed version — I will re-enable
> support for setuptools again of course as soon as upstream has sorted
> out these issues.

Interesting. Personally if I were upstream I'd drop the curl method and
go with pip but I understand it is a simple and thus useful hack.

How about this?

Rename icdiff to icdiff.py and make it a module.

Put a bin/icdiff in the repo that just imports and runs the icdiff
module. It can't be icdiff since people who run the same install
instructions should get a file not found error instead of confusing
import failure when trying to run the script.

Add some code to icdiff.py so it can be run on the cmdline too.

Update the web page curl install info to point at icdiff.py

Have setup.py install bin/icdiff as a script and icdiff.py as a module.

> New upload is here: https://mentors.debian.net/debian/pool/main/i/icdiff/icdiff_1.8.1-1.dsc

I'll take a look on the weekend.

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: