Hello,
Thank you for your review.
On Mon, Feb 29, 2016 at 11:25:22PM +0000, Mattia Rizzolo wrote:
> On Sat, Feb 06, 2016 at 06:11:40PM -0700, Sean Whitton wrote:
> > git clone https://anonscm.debian.org/git/pkg-emacsen/pkg/helm
> > git checkout debian/1.9.2-1
>
> there is no such tag (luckily?)
The Emacs Addons packaging team recently started using PET [1], which
works best if packages are tagged only after they are uploaded, so I
removed the tag.
I didn't expect anyone outside of the Emacs team to look at the RFS --
thanks again! -- so I decided not to spam debian-mentors with a message
saying I'd removed the tag.
By the way, please be sure to check out the pristine-tar branch so that
you use the same orig.tar as I'm working with :)
> anyway, looking at HEAD:
>
> * please use standards-versions 3.9.7
Done.
>
> * from the changelog:
> + "New dependency on elpa-popup." I don't see such thing in the
> debdiff generated
It's included in the ${elpa:Depends} substvar by dh_elpa, so it wouldn't
show up in debdiff.
> + "Update emacs-helm.sh patch for new upstream release." usually this
> is written like "Refresh patch <patch name, if you want>", I find
> hard to understand your sentence, tbh...
Cool, I've improved the changelog.
[1] https://pet.debian.net/pkg-emacsen/pet.cgi
--
Sean Whitton
Attachment:
signature.asc
Description: PGP signature