On Fri, Jan 22, 2016 at 02:55:38PM +0100, Pilisi Gergely wrote:
> First of all, thank you for the help. :) The new package is on the mentors
> site.
> I fixed this with exporting the build flags in the debian/rules file:
>
> export DEB_BUILD_MAINT_OPTIONS = hardening=+all
> export CPPFLAGS=$(shell dpkg-buildflags --get CPPFLAGS)
> export CFLAGS=$(shell dpkg-buildflags --get CFLAGS)
> export CXXFLAGS=$(shell dpkg-buildflags --get CXXFLAGS)
> export LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS)
> export CCFLAGS=$(shell dplg-buildflags --get CFLAGS)
oh, I see, you laso have CCFLAGS, which is kinda of non-standard (and as
such not exported.
> Now the code compiles perfectly, but I still can't see any hardening on the
> binaries.
> Lintian still throws hardening-no-fortify-functions and
> hardening-no-relro...
>
> What is wrong with that? :(
I'm pretty lost in this :\
I think this needs a more thorough look into the build system to
understan what's wrong with it, but these days I can't really look at
it.
So, given that those are still warnings (that would be nice to get rid
of), and that are for sure not blockers, what would you think about
uploading it as it's now and work on it on a later time?
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: http://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
Attachment:
signature.asc
Description: PGP signature